From: "Mickaël Salaün" <mic@digikod.net>
To: "Muhammad Usama Anjum" <usama.anjum@collabora.com>,
"Shuah Khan" <shuah@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Darren Hart" <dvhart@infradead.org>,
"Davidlohr Bueso" <dave@stgolabs.net>,
"André Almeida" <andrealmeid@collabora.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Mat Martineau" <mathew.j.martineau@linux.intel.com>,
"Matthieu Baerts" <matthieu.baerts@tessares.net>,
"Andrew Morton" <akpm@linux-foundation.org>,
chiminghao <chi.minghao@zte.com.cn>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:KERNEL VIRTUAL MACHINE (KVM)" <kvm@vger.kernel.org>,
"open list:LANDLOCK SECURITY MODULE"
<linux-security-module@vger.kernel.org>,
"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
"open list:NETWORKING [MPTCP]" <mptcp@lists.linux.dev>,
"open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>
Cc: kernel@collabora.com
Subject: Re: [PATCH V2 06/10] selftests: landlock: Add the uapi headers include variable
Date: Thu, 20 Jan 2022 19:20:38 +0100 [thread overview]
Message-ID: <4d2b0f3f-4783-3681-382d-4084c6bf79fc@digikod.net> (raw)
In-Reply-To: <20220119101531.2850400-7-usama.anjum@collabora.com>
On 19/01/2022 11:15, Muhammad Usama Anjum wrote:
> Out of tree build of this test fails if relative path of the output
> directory is specified. Add the KHDR_INCLUDES to correctly reach the
> headers.
>
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> Changes in V2:
> Revert the excessive cleanup which was breaking the individual
> test build.
> ---
> tools/testing/selftests/landlock/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/landlock/Makefile b/tools/testing/selftests/landlock/Makefile
> index a99596ca9882..0b0049e133bb 100644
> --- a/tools/testing/selftests/landlock/Makefile
> +++ b/tools/testing/selftests/landlock/Makefile
> @@ -1,6 +1,6 @@
> # SPDX-License-Identifier: GPL-2.0
>
> -CFLAGS += -Wall -O2
> +CFLAGS += -Wall -O2 $(KHDR_INCLUDES)
Reviewed-by: Mickaël Salaün <mic@linux.microsoft.com>
It works for me, but I'm wondering if a missing -I path could cause any
issue (cf. -I$(khdr_dir) bellow in this file). My GCC and clang ignore
such non-existent paths unless -Wmissing-include-dirs is used, which
would print a warning on your CI, but I guess that's OK.
>
> src_test := $(wildcard *_test.c)
>
next prev parent reply other threads:[~2022-01-20 18:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 10:15 [PATCH V2 00/10] selftests: Fix separate output directory builds Muhammad Usama Anjum
2022-01-19 10:15 ` [PATCH V2 01/10] selftests: set the BUILD variable to absolute path Muhammad Usama Anjum
2022-01-19 10:15 ` [PATCH V2 02/10] selftests: Add and export a kernel uapi headers path Muhammad Usama Anjum
2022-01-19 10:15 ` [PATCH V2 03/10] selftests: Correct the headers install path Muhammad Usama Anjum
2022-01-19 10:15 ` [PATCH V2 04/10] selftests: futex: Add the uapi headers include variable Muhammad Usama Anjum
2022-01-19 10:15 ` [PATCH V2 05/10] selftests: kvm: " Muhammad Usama Anjum
2022-01-19 10:15 ` [PATCH V2 06/10] selftests: landlock: " Muhammad Usama Anjum
2022-01-20 18:20 ` Mickaël Salaün [this message]
2022-01-19 10:15 ` [PATCH V2 07/10] selftests: net: " Muhammad Usama Anjum
2022-01-19 10:15 ` [PATCH V2 08/10] selftests: mptcp: " Muhammad Usama Anjum
2022-01-19 22:35 ` Matthieu Baerts
2022-01-19 10:15 ` [PATCH V2 09/10] selftests: vm: " Muhammad Usama Anjum
2022-01-20 1:18 ` Alistair Popple
2022-01-19 10:15 ` [PATCH V2 10/10] selftests: vm: remove dependecy from internal kernel macros Muhammad Usama Anjum
2022-01-20 1:20 ` Alistair Popple
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d2b0f3f-4783-3681-382d-4084c6bf79fc@digikod.net \
--to=mic@digikod.net \
--cc=akpm@linux-foundation.org \
--cc=andrealmeid@collabora.com \
--cc=chi.minghao@zte.com.cn \
--cc=dave@stgolabs.net \
--cc=davem@davemloft.net \
--cc=dvhart@infradead.org \
--cc=kernel@collabora.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=matthieu.baerts@tessares.net \
--cc=mingo@redhat.com \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).