From: Daniel Borkmann <dborkman@redhat.com>
To: Xi Wang <xi.wang@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] filter: fix va_list build error
Date: Wed, 01 May 2013 23:04:16 +0200 [thread overview]
Message-ID: <51818350.6040600@redhat.com> (raw)
In-Reply-To: <1367439848-10854-1-git-send-email-xi.wang@gmail.com>
On 05/01/2013 10:24 PM, Xi Wang wrote:
> This patch fixes the following build error.
>
> In file included from include/linux/filter.h:52:0,
> from arch/arm/net/bpf_jit_32.c:14:
> include/linux/printk.h:54:2: error: unknown type name ‘va_list’
> include/linux/printk.h:105:21: error: unknown type name ‘va_list’
> include/linux/printk.h:108:30: error: unknown type name ‘va_list’
>
> Signed-off-by: Xi Wang <xi.wang@gmail.com>
> ---
> include/linux/filter.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/filter.h b/include/linux/filter.h
> index d1248f4..c050dcc 100644
> --- a/include/linux/filter.h
> +++ b/include/linux/filter.h
> @@ -48,6 +48,7 @@ extern int sk_chk_filter(struct sock_filter *filter, unsigned int flen);
> extern int sk_get_filter(struct sock *sk, struct sock_filter __user *filter, unsigned len);
>
> #ifdef CONFIG_BPF_JIT
> +#include <stdarg.h>
> #include <linux/linkage.h>
> #include <linux/printk.h>
That's a bit weird. Xi, maybe in a follow-up some time later, could
you move the GCC-internal stdarg.h rather into linux/printk.h, since
that's where the problem is coming from? Imho, it might be better off
there, no?
next prev parent reply other threads:[~2013-05-01 21:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 20:24 [PATCH net-next] filter: fix va_list build error Xi Wang
2013-05-01 20:29 ` David Miller
2013-05-01 21:04 ` Daniel Borkmann [this message]
2013-05-01 22:29 ` Xi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51818350.6040600@redhat.com \
--to=dborkman@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=xi.wang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).