From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE24DC433F5 for ; Mon, 10 Jan 2022 11:21:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244616AbiAJLVU (ORCPT ); Mon, 10 Jan 2022 06:21:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244598AbiAJLVQ (ORCPT ); Mon, 10 Jan 2022 06:21:16 -0500 Received: from mail.marcansoft.com (marcansoft.com [IPv6:2a01:298:fe:f::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BF25C06173F; Mon, 10 Jan 2022 03:21:16 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id B8FCA41AC8; Mon, 10 Jan 2022 11:21:05 +0000 (UTC) Message-ID: <5226bf9f-fb0f-5dc5-3b82-2125fc229526@marcan.st> Date: Mon, 10 Jan 2022 20:21:03 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH v2 00/35] brcmfmac: Support Apple T2 and M1 platforms Content-Language: en-US To: Kalle Valo Cc: "David S. Miller" , Jakub Kicinski , Rob Herring , "Rafael J. Wysocki" , Len Brown , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Dmitry Osipenko , Sven Peter , Alyssa Rosenzweig , Mark Kettenis , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Pieter-Paul Giesberts , Linus Walleij , Hans de Goede , "John W. Linville" , "brian m. carlson" , Andy Shevchenko , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com References: <20220104072658.69756-1-marcan@marcan.st> <87tuebvqw4.fsf@kernel.org> From: Hector Martin In-Reply-To: <87tuebvqw4.fsf@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2022/01/10 19:14, Kalle Valo wrote: > Hector Martin writes: > >> Hi everyone, >> >> Happy new year! This 35-patch series adds proper support for the >> Broadcom FullMAC chips used on Apple T2 and M1 platforms: >> >> - BCM4355C1 >> - BCM4364B2/B3 >> - BCM4377B3 >> - BCM4378B1 >> - BCM4387C2 > > 35 patches is a lot to review. It would make things easier for reviewers > if you can split this into smaller patchsets, 10-12 patches per set is > what I usually recommend. More info in the wiki link below. The patches are already split into logical groupings, so I think there isn't much more to be gained by sending them separately. As I described in the cover letter: 01~09: Firmware selection stuff 10~14: Add support for BCM4378 15~20: Add BCM4355/4364/4377 on top 21~27: Add BCM4387 and its newer requirements 28~32: Misc fixes 33~35: TxCap & calibration support If you want to review the series piecemeal, feel free to stop at any of those boundaries; the series will still make sense and is useful at any of those stopping points. Note that the firmware selection stuff (in particular patches #4 and #6) will change quite a bit in v3 from the review feedback so far, so you might want to skip reviewing those in detail for v2. -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub