From: "Jan Beulich" <JBeulich@suse.com>
To: "Gustavo A.R.Silva" <gustavo@embeddedor.com>
Cc: "Paul Durrant" <paul.durrant@citrix.com>,
"Wei Liu" <wei.liu2@citrix.com>, <davem@davemloft.net>,
"xen-devel" <xen-devel@lists.xenproject.org>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH net-next] xen-netback: mark expected switch fall-through
Date: Mon, 11 Feb 2019 02:50:24 -0700 [thread overview]
Message-ID: <5C6145600200007800215864@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <20190208195838.GA11878@embeddedor>
>>> On 08.02.19 at 20:58, <gustavo@embeddedor.com> wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/net/xen-netback/xenbus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/xen-netback/xenbus.c
> b/drivers/net/xen-netback/xenbus.c
> index 2625740bdc4a..330ddb64930f 100644
> --- a/drivers/net/xen-netback/xenbus.c
> +++ b/drivers/net/xen-netback/xenbus.c
> @@ -655,7 +655,7 @@ static void frontend_changed(struct xenbus_device *dev,
> set_backend_state(be, XenbusStateClosed);
> if (xenbus_dev_is_online(dev))
> break;
> - /* fall through if not online */
> + /* fall through - if not online */
> case XenbusStateUnknown:
Considering the fall-through was already annotated, I don't think
title and description really justify the change. Is the compiler after
a particular wording here?
Jan
prev parent reply other threads:[~2019-02-11 9:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 19:58 [PATCH net-next] xen-netback: mark expected switch fall-through Gustavo A. R. Silva
2019-02-08 20:21 ` David Miller
2019-02-08 21:00 ` Gustavo A. R. Silva
2019-02-11 9:50 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C6145600200007800215864@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=davem@davemloft.net \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.durrant@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).