From: John Fastabend <john.fastabend@gmail.com>
To: Jakub Sitnicki <jakub@cloudflare.com>,
John Fastabend <john.fastabend@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org, Marek Majkowski <marek@cloudflare.com>
Subject: Re: [PATCH net] sk_msg: Keep reference on socket file while psock lives
Date: Thu, 23 May 2019 08:58:28 -0700 [thread overview]
Message-ID: <5ce6c32418618_64ba2ad730e1a5b44@john-XPS-13-9360.notmuch> (raw)
In-Reply-To: <87v9y2zqpz.fsf@cloudflare.com>
[...]
>
> Thanks for taking a look at it. Setting MSG_DONTWAIT works great for
> me. No more crashes in sk_stream_wait_memory. I've tested it on top of
> current bpf-next (f49aa1de9836). Here's my:
>
> Tested-by: Jakub Sitnicki <jakub@cloudflare.com>
>
> The actual I've tested is below, for completeness.
>
> BTW. I've ran into another crash which I haven't seen before while
> testing sockmap-echo, but it looks unrelated:
>
> https://lore.kernel.org/netdev/20190522100142.28925-1-jakub@cloudflare.com/
>
> -Jakub
>
> --- 8< ---
>
> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> index e89be6282693..4a7c656b195b 100644
> --- a/net/core/skbuff.c
> +++ b/net/core/skbuff.c
> @@ -2337,6 +2337,7 @@ int skb_send_sock_locked(struct sock *sk, struct sk_buff *skb, int offset,
> kv.iov_base = skb->data + offset;
> kv.iov_len = slen;
> memset(&msg, 0, sizeof(msg));
> + msg.msg_flags = MSG_DONTWAIT;
>
> ret = kernel_sendmsg_locked(sk, &msg, &kv, 1, slen);
> if (ret <= 0)
I went ahead and submitted this feel free to add your signed-off-by.
Thanks,
John
next prev parent reply other threads:[~2019-05-23 15:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 9:09 [PATCH net] sk_msg: Keep reference on socket file while psock lives Jakub Sitnicki
2019-02-19 16:00 ` Daniel Borkmann
2019-02-20 9:47 ` Jakub Sitnicki
2019-05-21 20:07 ` John Fastabend
2019-05-22 11:14 ` Jakub Sitnicki
2019-05-23 15:58 ` John Fastabend [this message]
2019-05-24 8:05 ` Jakub Sitnicki
2019-05-24 15:51 ` John Fastabend
2019-05-27 9:27 ` Jakub Sitnicki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ce6c32418618_64ba2ad730e1a5b44@john-XPS-13-9360.notmuch \
--to=john.fastabend@gmail.com \
--cc=daniel@iogearbox.net \
--cc=jakub@cloudflare.com \
--cc=marek@cloudflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).