From: "Arınç ÜNAL" <arinc.unal@arinc9.com>
To: Daniel Golle <daniel@makrotopia.org>,
Vladimir Oltean <olteanv@gmail.com>
Cc: Landen Chao <Landen.Chao@mediatek.com>,
DENG Qingfang <dqfext@gmail.com>,
Sean Wang <sean.wang@mediatek.com>, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
mithat.guner@xeront.com, erkin.bozoglu@xeront.com,
Luiz Angelo Daros de Luca <luizluca@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [RFC PATCH net-next 7/8] net: dsa: mt7530: correct port capabilities of MT7988
Date: Tue, 16 Jan 2024 16:31:34 +0300 [thread overview]
Message-ID: <656cf9e2-2ab9-48ea-9eea-7599f14f3a41@arinc9.com> (raw)
In-Reply-To: <ZaWtIMC9zqwjVewO@makrotopia.org>
On 16.01.2024 01:09, Daniel Golle wrote:
> On Mon, Jan 15, 2024 at 11:42:38PM +0200, Vladimir Oltean wrote:
>> On Sat, Jan 13, 2024 at 01:25:28PM +0300, Arınç ÜNAL wrote:
>>> On the switch on the MT7988 SoC, there are only 4 PHYs. That's port 0 to 3.
>>> Set the internal phy cases to '0 ... 3'.
>>>
>>> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
>>> Acked-by: Daniel Golle <daniel@makrotopia.org>
>>> ---
>>
>> For this patch to be obviously correct, please make a statement in the
>> commit message about port 4. It doesn't exist at all?
>
> Correct. As shown in Block Diagram 8.1.1.3 on page 125 of
> MT7988A Wi-Fi 7 Generation Router Platform: Datasheet (Open Version)
> Version: 0.1
> Release Date: 2023-10-18
> which is available publicly on BananaPi's Wiki[1].
>
> Port 0~3 are TP user ports, Port 6 is internally linked to XGMII of MAC 0.
> Port 4 and 5 are not used at all in this design.
>
> [1]: https://wiki.banana-pi.org/Banana_Pi_BPI-R4#Documents
Thanks for chiming in Daniel, I will include this on the patch log.
Arınç
next prev parent reply other threads:[~2024-01-16 13:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-13 10:25 [RFC PATCH net-next 0/8] MT7530 DSA Subdriver Improvements Act II Arınç ÜNAL
2024-01-13 10:25 ` [RFC PATCH net-next 1/8] net: dsa: mt7530: empty default case on mt7530_setup_port5() Arınç ÜNAL
2024-01-13 10:25 ` [RFC PATCH net-next 2/8] net: dsa: mt7530: call port 6 setup from mt7530_mac_config() Arınç ÜNAL
2024-01-13 10:25 ` [RFC PATCH net-next 3/8] net: dsa: mt7530: remove pad_setup function pointer Arınç ÜNAL
2024-01-13 10:25 ` [RFC PATCH net-next 4/8] net: dsa: mt7530: move XTAL check to mt7530_setup() Arınç ÜNAL
2024-01-15 21:20 ` Vladimir Oltean
2024-01-13 10:25 ` [RFC PATCH net-next 5/8] net: dsa: mt7530: move enabling port 6 to mt7530_setup_port6() Arınç ÜNAL
2024-01-15 21:24 ` Vladimir Oltean
2024-01-13 10:25 ` [RFC PATCH net-next 6/8] net: dsa: mt7530: simplify mt7530_setup_port6() and change to void Arınç ÜNAL
2024-01-15 21:37 ` Vladimir Oltean
2024-01-16 13:09 ` Arınç ÜNAL
2024-01-16 13:47 ` Vladimir Oltean
2024-01-16 17:05 ` Arınç ÜNAL
2024-01-13 10:25 ` [RFC PATCH net-next 7/8] net: dsa: mt7530: correct port capabilities of MT7988 Arınç ÜNAL
2024-01-15 21:42 ` Vladimir Oltean
2024-01-15 22:09 ` Daniel Golle
2024-01-16 13:31 ` Arınç ÜNAL [this message]
2024-01-13 10:25 ` [RFC PATCH net-next 8/8] net: dsa: mt7530: do not clear config->supported_interfaces Arınç ÜNAL
2024-01-15 21:46 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=656cf9e2-2ab9-48ea-9eea-7599f14f3a41@arinc9.com \
--to=arinc.unal@arinc9.com \
--cc=Landen.Chao@mediatek.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=erkin.bozoglu@xeront.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=luizluca@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=mithat.guner@xeront.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).