From: 孙守鑫 <sunshouxin@chinatelecom.cn>
To: Jay Vosburgh <jay.vosburgh@canonical.com>
Cc: vfalico@gmail.com, andy@greyhouse.net, davem@davemloft.net,
kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, huyd12@chinatelecom.cn
Subject: Re: [PATCH v6] net: bonding: Add support for IPV6 ns/na to balance-alb/balance-tlb mode
Date: Fri, 21 Jan 2022 14:38:03 +0800 [thread overview]
Message-ID: <661de9e7-216d-dfd1-afdc-3c58a88739c3@chinatelecom.cn> (raw)
In-Reply-To: <29469.1642746326@famine>
在 2022/1/21 14:25, Jay Vosburgh 写道:
> Sun Shouxin <sunshouxin@chinatelecom.cn> wrote:
>
>> Since ipv6 neighbor solicitation and advertisement messages
>> isn't handled gracefully in bonding6 driver, we can see packet
>> drop due to inconsistency bewteen mac address in the option
>> message and source MAC .
>>
>> Another examples is ipv6 neighbor solicitation and advertisement
>> messages from VM via tap attached to host brighe, the src mac
>> mighe be changed through balance-alb mode, but it is not synced
>> with Link-layer address in the option message.
>>
>> The patch implements bond6's tx handle for ipv6 neighbor
>> solicitation and advertisement messages.
> As previously discussed, this looks reasonable to me to resolve
> the described MAC discrepancy. One minor nit is a couple of misspelled
> words in the description above, "brighe" and "mighe."
>
> Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com>
>
> -J
Thanks your comment, I'll adjust it and send out V7 soon.
>
>> Suggested-by: Hu Yadi <huyd12@chinatelecom.cn>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Sun Shouxin <sunshouxin@chinatelecom.cn>
>> ---
>> drivers/net/bonding/bond_alb.c | 36 ++++++++++++++++++++++++++++++++++
>> 1 file changed, 36 insertions(+)
>>
>> diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c
>> index 533e476988f2..82b7071840b1 100644
>> --- a/drivers/net/bonding/bond_alb.c
>> +++ b/drivers/net/bonding/bond_alb.c
>> @@ -1269,6 +1269,34 @@ static int alb_set_mac_address(struct bonding *bond, void *addr)
>> return res;
>> }
>>
>> +/*determine if the packet is NA or NS*/
>> +static bool __alb_determine_nd(struct icmp6hdr *hdr)
>> +{
>> + if (hdr->icmp6_type == NDISC_NEIGHBOUR_ADVERTISEMENT ||
>> + hdr->icmp6_type == NDISC_NEIGHBOUR_SOLICITATION) {
>> + return true;
>> + }
>> +
>> + return false;
>> +}
>> +
>> +static bool alb_determine_nd(struct sk_buff *skb, struct bonding *bond)
>> +{
>> + struct ipv6hdr *ip6hdr;
>> + struct icmp6hdr *hdr;
>> +
>> + if (skb->protocol == htons(ETH_P_IPV6)) {
>> + ip6hdr = ipv6_hdr(skb);
>> + if (ip6hdr->nexthdr == IPPROTO_ICMPV6) {
>> + hdr = icmp6_hdr(skb);
>> + if (__alb_determine_nd(hdr))
>> + return true;
>> + }
>> + }
>> +
>> + return false;
>> +}
>> +
>> /************************ exported alb functions ************************/
>>
>> int bond_alb_initialize(struct bonding *bond, int rlb_enabled)
>> @@ -1350,6 +1378,9 @@ struct slave *bond_xmit_tlb_slave_get(struct bonding *bond,
>> switch (skb->protocol) {
>> case htons(ETH_P_IP):
>> case htons(ETH_P_IPV6):
>> + if (alb_determine_nd(skb, bond))
>> + break;
>> +
>> hash_index = bond_xmit_hash(bond, skb);
>> if (bond->params.tlb_dynamic_lb) {
>> tx_slave = tlb_choose_channel(bond,
>> @@ -1446,6 +1477,11 @@ struct slave *bond_xmit_alb_slave_get(struct bonding *bond,
>> break;
>> }
>>
>> + if (alb_determine_nd(skb, bond)) {
>> + do_tx_balance = false;
>> + break;
>> + }
>> +
>> hash_start = (char *)&ip6hdr->daddr;
>> hash_size = sizeof(ip6hdr->daddr);
>> break;
>>
>> base-commit: 79e06c4c4950be2abd8ca5d2428a8c915aa62c24
>> --
>> 2.27.0
>>
> ---
> -Jay Vosburgh, jay.vosburgh@canonical.com
next prev parent reply other threads:[~2022-01-21 6:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 7:33 [PATCH v6] net: bonding: Add support for IPV6 ns/na to balance-alb/balance-tlb mode Sun Shouxin
2022-01-21 6:25 ` Jay Vosburgh
2022-01-21 6:38 ` 孙守鑫 [this message]
2022-01-21 15:46 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=661de9e7-216d-dfd1-afdc-3c58a88739c3@chinatelecom.cn \
--to=sunshouxin@chinatelecom.cn \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=huyd12@chinatelecom.cn \
--cc=jay.vosburgh@canonical.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).