From: Murali Karicheri <m-karicheri2@ti.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Vinicius Costa Gomes <vinicius.gomes@intel.com>,
Po Liu <po.liu@nxp.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"hauke.mehrtens@intel.com" <hauke.mehrtens@intel.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"allison@lohutok.net" <allison@lohutok.net>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"saeedm@mellanox.com" <saeedm@mellanox.com>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"alexandru.ardelean@analog.com" <alexandru.ardelean@analog.com>,
"jiri@mellanox.com" <jiri@mellanox.com>,
"ayal@mellanox.com" <ayal@mellanox.com>,
"pablo@netfilter.org" <pablo@netfilter.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"simon.horman@netronome.com" <simon.horman@netronome.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Alexandru Marginean <alexandru.marginean@nxp.com>,
Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
Roy Zang <roy.zang@nxp.com>, Mingkai Hu <mingkai.hu@nxp.com>,
Jerry Huang <jerry.huang@nxp.com>, Leo Li <leoyang.li@nxp.com>
Subject: Re: [v1,net-next, 1/2] ethtool: add setting frame preemption of traffic classes
Date: Mon, 10 Feb 2020 15:17:13 -0500 [thread overview]
Message-ID: <700c20c2-6112-100f-d198-40ee74a167c1@ti.com> (raw)
In-Reply-To: <CA+h21hqk2pCfrQg5kC6HzmL=eEqJXjuRsu+cVkGsEi8OXGpKJA@mail.gmail.com>
Hi Vladimir,
On 01/23/2020 08:30 AM, Vladimir Oltean wrote:
> Hi Murali,
>
> On Wed, 22 Jan 2020 at 20:04, Murali Karicheri <m-karicheri2@ti.com> wrote:
>>
>> I have question about the below parameters in The Gate Parameter Table
>> that are not currently supported by tc command. Looks like they need to
>> be shown to user for management.
>>
>> - ConfigChange - Looks like this needs to be controlled by
>> user. After sending admin command, user send this trigger to start
>> copying admin schedule to operation schedule. Is this getting
>> added to tc command?
>
> "The ConfigChange parameter signals the start of a
> configuration change for the gate
> when it is set to TRUE. This should only be done
> when the various administrative parameters
> are all set to appropriate values."
>
> As far as my understanding goes, all tc-taprio commands currently
> behave as though this boolean is implicitly set to TRUE after the
> structures have been set up. I'm not sure there is any value in doing
> otherwise.
>
That is my understanding as well. However I found this in the 802.1Q
and want to see if someone has insight into this parameter. So perhaps
we can ignore this for now and re-visit when there is a real need for
the same.
>> - ConfigChangeTime - The time at which the administrative variables
>> that determine the cycle are to be copied across to the
>> corresponding operational variables, expressed as a PTP timescale
>
> This is the base-time of the admin schedule, no?
I think there is cycle time extension possible and in that case,
ConfigChangeTime may be different from Admin base-time. So this gives
the actual time when the cycle configuration is actually applied.
>
> "The PTPtime at which the next config change is scheduled to occur.
> The value is a representation of a PTPtime value,
> consisting of a 48-bit integer
> number of seconds and a 32-bit integer number of nanoseconds."
>
>> - TickGranularity - the management parameters specified in Gate
>> Parameter Table allow a management station to discover the
>> characteristics of an implementation’s cycle timer clock
>> (TickGranularity) and to set the parameters for the gating cycle
>> accordingly.
>
> Not sure who is going to use this and for what purpose, but ok.
Same here. Not sure how this will be used by application.
>
>> - ConfigPending - A Boolean variable, set TRUE to indicate that
>> there is a new cycle configuration awaiting installation.
>
> I had tried to export something like this (driver calls back into
> sch_taprio.c when hw has applied the config, this would result in
> ConfigPending = FALSE), but ultimately didn't finish the idea, and it
> caused some problems too, due to incorrect RCU usage.
>
Ok. Hope you plan to send a patch for this in the future.
>> - ConfigChangeError - Error in configuration (AdminBaseTime <
>> CurrentTime)
>
> This can be exported similarly.
Ok.
>
>> - SupportedListMax - Maximum supported Admin/Open shed list.
>>
>> Is there a plan to export these from driver through tc show or such
>> command? The reason being, there would be applications developed to
>> manage configuration/schedule of TSN nodes that would requires these
>> information from the node. So would need a support either in tc or
>> some other means to retrieve them from hardware or driver. That is my
>> understanding...
>>
>
> Not sure what answer you expect to receive for "is there any plan".
To avoid duplicating the work if someone is already working on this.
> You can go ahead and propose something, as long as it is reasonably
> useful to have.
Ok. Will keep in mind.
>
>> Regards,
>>
>> Murali
>>
>> --
>> Murali Karicheri
>> Texas Instruments
>
> Thanks,
> -Vladimir
>
--
Murali Karicheri
Texas Instruments
next prev parent reply other threads:[~2020-02-10 20:10 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 9:59 [v1,net-next, 1/2] ethtool: add setting frame preemption of traffic classes Po Liu
2019-11-27 9:59 ` [v1,net-next, 2/2] enetc: implement the enetc 802.1Qbu hardware function Po Liu
2019-11-27 11:00 ` Vladimir Oltean
2019-12-04 1:35 ` Ivan Khoronzhuk
2019-11-27 18:57 ` [v1,net-next, 1/2] ethtool: add setting frame preemption of traffic classes David Miller
2019-12-03 15:11 ` Ivan Khoronzhuk
2019-12-11 2:52 ` Andre Guedes
2019-12-16 7:43 ` [EXT] " Po Liu
2019-12-16 21:44 ` Vinicius Costa Gomes
2019-12-19 0:43 ` Ivan Khoronzhuk
2019-12-19 1:54 ` Vinicius Costa Gomes
2019-12-30 16:56 ` Murali Karicheri
2020-01-17 23:47 ` Vinicius Costa Gomes
2019-12-30 17:03 ` Murali Karicheri
2020-01-09 1:07 ` Andre Guedes
2020-01-09 8:59 ` Jose Abreu
2020-01-09 18:04 ` Andre Guedes
2020-01-10 14:35 ` Jose Abreu
2020-01-10 16:02 ` Vladimir Oltean
2020-01-10 20:59 ` Andre Guedes
2020-01-09 0:56 ` Andre Guedes
2020-01-18 0:03 ` Vinicius Costa Gomes
2020-01-22 18:10 ` Murali Karicheri
2020-01-23 13:30 ` Vladimir Oltean
2020-01-23 17:50 ` Vinicius Costa Gomes
2020-02-10 20:30 ` Murali Karicheri
2020-02-11 19:22 ` Vinicius Costa Gomes
2020-02-25 17:55 ` Murali Karicheri
2020-02-10 20:17 ` Murali Karicheri [this message]
2020-02-21 21:43 ` Vinicius Costa Gomes
2020-02-22 3:26 ` [EXT] " Po Liu
2020-02-25 17:59 ` Murali Karicheri
2020-02-25 17:59 ` Murali Karicheri
2020-02-26 2:01 ` Po Liu
2020-03-12 23:34 ` Vinicius Costa Gomes
2020-03-13 6:00 ` Po Liu
2020-03-18 14:07 ` Murali Karicheri
2020-05-13 14:55 ` Murali Karicheri
2020-05-13 17:21 ` Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=700c20c2-6112-100f-d198-40ee74a167c1@ti.com \
--to=m-karicheri2@ti.com \
--cc=alexandru.ardelean@analog.com \
--cc=alexandru.marginean@nxp.com \
--cc=allison@lohutok.net \
--cc=andrew@lunn.ch \
--cc=ayal@mellanox.com \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hauke.mehrtens@intel.com \
--cc=hkallweit1@gmail.com \
--cc=jerry.huang@nxp.com \
--cc=jiri@mellanox.com \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingkai.hu@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pablo@netfilter.org \
--cc=po.liu@nxp.com \
--cc=roy.zang@nxp.com \
--cc=saeedm@mellanox.com \
--cc=simon.horman@netronome.com \
--cc=tglx@linutronix.de \
--cc=vinicius.gomes@intel.com \
--cc=vladimir.oltean@nxp.com \
--cc=xiaoliang.yang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).