From: David Ahern <dsahern@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
Jiri Pirko <jiri@resnulli.us>,
davem@davemloft.net, "dsahern@gmail.com" <dsahern@gmail.com>
Cc: netdev@vger.kernel.org, ayal@mellanox.com, moshe@mellanox.com,
eranbe@mellanox.com, mlxsw@mellanox.com
Subject: Re: [patch net-next v2 2/4] devlink: propagate extack down to health reporter ops
Date: Fri, 11 Oct 2019 17:10:35 -0600 [thread overview]
Message-ID: <7889db74-817c-9558-f86f-a4e4c829c1fb@gmail.com> (raw)
In-Reply-To: <4aba888eb7ae08b446aa1140df729bca93cb0d33.camel@sipsolutions.net>
On 10/11/19 12:45 AM, Johannes Berg wrote:
> So to me this looks fine.
>
> I don't really share the concern about extack being netlink specific and
> then using it here - it ultimately doesn't matter whether this thing is
> called "netlink_extack" or "extended_error_reporting", IMHO.
+1
next prev parent reply other threads:[~2019-10-11 23:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 13:18 [patch net-next v2 0/4] netdevsim: add devlink health reporters suppor Jiri Pirko
2019-10-10 13:18 ` [patch net-next v2 1/4] devlink: don't do reporter recovery if the state is healthy Jiri Pirko
2019-10-10 13:18 ` [patch net-next v2 2/4] devlink: propagate extack down to health reporter ops Jiri Pirko
2019-10-11 2:04 ` Jakub Kicinski
2019-10-11 6:13 ` Jiri Pirko
2019-10-11 6:45 ` Johannes Berg
2019-10-11 23:10 ` David Ahern [this message]
2019-10-10 13:18 ` [patch net-next v2 3/4] netdevsim: implement couple of testing devlink health reporters Jiri Pirko
2019-10-10 13:18 ` [patch net-next v2 4/4] selftests: add netdevsim devlink health tests Jiri Pirko
2019-10-12 4:05 ` [patch net-next v2 0/4] netdevsim: add devlink health reporters suppor David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7889db74-817c-9558-f86f-a4e4c829c1fb@gmail.com \
--to=dsahern@gmail.com \
--cc=ayal@mellanox.com \
--cc=davem@davemloft.net \
--cc=eranbe@mellanox.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=johannes@sipsolutions.net \
--cc=mlxsw@mellanox.com \
--cc=moshe@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).