From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: idosch@mellanox.com, linux-kernel@vger.kernel.org,
devel@driverdev.osuosl.org, bridge@lists.linux-foundation.org,
jiri@mellanox.com, andrew@lunn.ch, vivien.didelot@gmail.com
Subject: Re: [PATCH net-next v3 0/9] net: Remove switchdev_ops
Date: Mon, 11 Feb 2019 09:31:42 -0800 [thread overview]
Message-ID: <7ece5de8-1bab-0f0e-e7db-ffeef12ba1d7@gmail.com> (raw)
In-Reply-To: <20190210234007.16173-1-f.fainelli@gmail.com>
On 2/10/19 3:39 PM, Florian Fainelli wrote:
> Hi all,
>
> This patch series finishes by the removal of switchdev_ops. To get there
> we need to do a few things:
>
> - get rid of the one and only call to switchdev_port_attr_get() which is
> used to fetch the device's bridge port flags capabilities, instead we
> can just check what flags are being programmed during the prepare
> phase
>
> - once we get rid of getting switchdev port attributes we convert the
> setting of such attributes using a blocking notifier
>
> And then remove switchdev_ops completely.
>
> Please review and let me know what you think!
>
> David, I would like to get Ido's feedback on this to make sure I did not
> miss something, thank you!
David, I will be reposting a v4 with Jiri's Acked-by as well as adding
fallthrough switch/case annotations so we don't regress on that front.
Thank you.
>
> Changes in v3:
> - dropped patches removing te need to get the attribute since we
> still need that in order to support different sleeping vs.
> non-sleeping contexts
>
> Changes in v2:
> - fixed bisectability issues in patch #15
> - added Acked-by from Jiri where necessary
> - fixed a few minor issues according to Jiri's feedback:
> - rename port_attr_event -> port_attr_set_event
> - moved SWITCHDEV_PORT_ATTR_SET closer to other blocking events
>
> Florian Fainelli (9):
> Documentation: networking: switchdev: Update port parent ID section
> switchdev: Add SWITCHDEV_PORT_ATTR_SET, SWITCHDEV_PORT_ATTR_GET
> rocker: Handle SWITCHDEV_PORT_ATTR_GET/SET
> mlxsw: spectrum_switchdev: Handle SWITCHDEV_PORT_ATTR_GET/SET
> net: mscc: ocelot: Handle SWITCHDEV_PORT_ATTR_GET/SET
> staging: fsl-dpaa2: ethsw: Handle SWITCHDEV_PORT_ATTR_GET/SET
> net: dsa: Handle SWITCHDEV_PORT_ATTR_GET/SET
> net: switchdev: Replace port attr get/set SDO with a notification
> net: Remove switchdev_ops
>
> Documentation/networking/switchdev.txt | 10 +-
> .../net/ethernet/mellanox/mlxsw/spectrum.c | 12 --
> .../net/ethernet/mellanox/mlxsw/spectrum.h | 2 -
> .../mellanox/mlxsw/spectrum_switchdev.c | 36 +++---
> drivers/net/ethernet/mscc/ocelot.c | 26 ++++-
> drivers/net/ethernet/rocker/rocker_main.c | 30 ++++-
> drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 30 ++++-
> include/linux/netdevice.h | 3 -
> include/net/switchdev.h | 28 ++---
> net/dsa/slave.c | 30 ++++-
> net/switchdev/switchdev.c | 107 ++++++------------
> 11 files changed, 168 insertions(+), 146 deletions(-)
>
--
Florian
next prev parent reply other threads:[~2019-02-11 17:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-10 23:39 [PATCH net-next v3 0/9] net: Remove switchdev_ops Florian Fainelli
2019-02-10 23:39 ` [PATCH net-next v3 1/9] Documentation: networking: switchdev: Update port parent ID section Florian Fainelli
2019-02-11 12:19 ` Jiri Pirko
2019-02-10 23:40 ` [PATCH net-next v3 2/9] switchdev: Add SWITCHDEV_PORT_ATTR_SET, SWITCHDEV_PORT_ATTR_GET Florian Fainelli
2019-02-11 12:19 ` Jiri Pirko
2019-02-10 23:40 ` [PATCH net-next v3 3/9] rocker: Handle SWITCHDEV_PORT_ATTR_GET/SET Florian Fainelli
2019-02-11 12:20 ` Jiri Pirko
2019-02-10 23:40 ` [PATCH net-next v3 4/9] mlxsw: spectrum_switchdev: " Florian Fainelli
2019-02-11 12:28 ` Jiri Pirko
2019-02-10 23:40 ` [PATCH net-next v3 5/9] net: mscc: ocelot: " Florian Fainelli
2019-02-11 12:29 ` Jiri Pirko
2019-02-10 23:40 ` [PATCH net-next v3 6/9] staging: fsl-dpaa2: ethsw: " Florian Fainelli
2019-02-11 12:30 ` Jiri Pirko
2019-02-10 23:40 ` [PATCH net-next v3 7/9] net: dsa: " Florian Fainelli
2019-02-11 12:31 ` Jiri Pirko
2019-02-10 23:40 ` [PATCH net-next v3 8/9] net: switchdev: Replace port attr get/set SDO with a notification Florian Fainelli
2019-02-11 12:39 ` Jiri Pirko
2019-02-10 23:40 ` [PATCH net-next v3 9/9] net: Remove switchdev_ops Florian Fainelli
2019-02-11 12:51 ` Jiri Pirko
2019-02-11 17:31 ` Florian Fainelli [this message]
2019-02-11 18:46 ` [PATCH net-next v3 0/9] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ece5de8-1bab-0f0e-e7db-ffeef12ba1d7@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=bridge@lists.linux-foundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).