netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Eelco Chaudron" <echaudro@redhat.com>
To: "Sebastian Andrzej Siewior" <bigeasy@linutronix.de>
Cc: netdev@vger.kernel.org, davem@davemloft.net, dev@openvswitch.org,
	kuba@kernel.org, pabeni@redhat.com, pshelar@ovn.org,
	jlelli@redhat.com
Subject: Re: [PATCH net-next] net: openvswitch: fix to make sure flow_lookup() is not preempted
Date: Thu, 15 Oct 2020 10:11:31 +0200	[thread overview]
Message-ID: <80D4D885-0E28-4B29-8C1E-34F5FBB6CF38@redhat.com> (raw)
In-Reply-To: <20201015075517.gjsebwhqznj6ypm3@linutronix.de>



On 15 Oct 2020, at 9:55, Sebastian Andrzej Siewior wrote:

> On 2020-10-14 12:44:23 [+0200], Eelco Chaudron wrote:
>> Let me know your thoughts.
>
> better. If your seccount is per-CPU then you get away without explicit
> writer locking if you rely on global per-CPU locking. You can't do
> preempt_disable() because this section can be interrupt by softirq. 
> You
> need something stronger :)

Thanks for your reply! Yes I had it replaced with local_bh_disable() in 
my v2, as I noticed the hard IRQ to softirq part earlier.

> Side note: Adding a fixes tag and net-next looks like "stable material
> starting next merge window".

Have the patch on net-next, but will send it out on next (will do the 
conversion later today and sent it out).

Thanks,

Eelco


  reply	other threads:[~2020-10-15  8:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-13 12:44 [PATCH net-next] net: openvswitch: fix to make sure flow_lookup() is not preempted Eelco Chaudron
2020-10-13 12:53 ` Sebastian Andrzej Siewior
2020-10-14 10:44   ` Eelco Chaudron
2020-10-15  7:55     ` Sebastian Andrzej Siewior
2020-10-15  8:11       ` Eelco Chaudron [this message]
2020-10-15  8:15         ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80D4D885-0E28-4B29-8C1E-34F5FBB6CF38@redhat.com \
    --to=echaudro@redhat.com \
    --cc=bigeasy@linutronix.de \
    --cc=davem@davemloft.net \
    --cc=dev@openvswitch.org \
    --cc=jlelli@redhat.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pshelar@ovn.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).