From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CBE7C433FE for ; Mon, 10 Jan 2022 13:55:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234883AbiAJNzL (ORCPT ); Mon, 10 Jan 2022 08:55:11 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:41362 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234685AbiAJNzH (ORCPT ); Mon, 10 Jan 2022 08:55:07 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CFE8DB81654; Mon, 10 Jan 2022 13:55:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7BBDDC36AE5; Mon, 10 Jan 2022 13:54:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641822904; bh=rj4fKmBFoTHA0iE6ZmISK6tpcbjzpc6k3C0OppRQfXI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=mLOFKpfG5t6VcVdIo8HnBo4TNSUN0tKjo69CxcZVSODX4E/wp4Qq2JAJ/RDV2iBbg 18oBED1NTpckFJA7zbUwmTe1QZE4Wrro1ocg82W3n7wpQftGoLJTQU3AGP/LJ9nGtl Q1izKRVSRFl6rZoA9r+DPbZMSAWeVNeOvLI1TwuOkyOMR0Vxizmi4PdQpSPxz5GxbU IUGNwPnsHWCL6bNde0DXS2J3fJM+zoTRiiZyZjjXvYXH9EbYJcQEeV9hygDLBG7CEx yorgSW3rmF3Zs+Ti399XXtPitqyOhR30/IelIneFxcNpCUNwpdPhrkyTKHSXYqYfRA etY7UfhX/G3nQ== From: Kalle Valo To: Hector Martin Cc: Andy Shevchenko , "David S. Miller" , Jakub Kicinski , Rob Herring , "Rafael J. Wysocki" , Len Brown , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Dmitry Osipenko , Sven Peter , Alyssa Rosenzweig , Mark Kettenis , =?utf-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , Pieter-Paul Giesberts , Linus Walleij , Hans de Goede , "John W. Linville" , "brian m. carlson" , "open list\:TI WILINK WIRELES..." , netdev , devicetree , Linux Kernel Mailing List , ACPI Devel Maling List , "open list\:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" , SHA-cyfmac-dev-list@infineon.com Subject: Re: [PATCH v2 12/35] brcmfmac: pcie: Fix crashes due to early IRQs References: <20220104072658.69756-1-marcan@marcan.st> <20220104072658.69756-13-marcan@marcan.st> <759f46bd-bfc2-62c6-6257-a2a0d702e2b6@marcan.st> Date: Mon, 10 Jan 2022 15:54:54 +0200 In-Reply-To: <759f46bd-bfc2-62c6-6257-a2a0d702e2b6@marcan.st> (Hector Martin's message of "Thu, 6 Jan 2022 22:10:45 +0900") Message-ID: <87bl0jlmq9.fsf@tynnyri.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hector Martin writes: > On 04/01/2022 23.12, Andy Shevchenko wrote: >> On Tue, Jan 4, 2022 at 9:29 AM Hector Martin wrote: >>> >>> The driver was enabling IRQs before the message processing was >>> initialized. This could cause IRQs to come in too early and crash the >>> driver. Instead, move the IRQ enable and hostready to a bus preinit >>> function, at which point everything is properly initialized. >>> >>> Fixes: 9e37f045d5e7 ("brcmfmac: Adding PCIe bus layer support.") >> >> You should gather fixes at the beginning of the series, and even >> possible to send them as a separate series. In the current state it's >> unclear if there are dependencies on your new feature (must not be for >> fixes that meant to be backported). >> > > Thanks, I wasn't sure what order you wanted those in. I'll put them at > the top for v3. I think none of those should have any dependencies on > the rest of the patches, modulo some trivial rebase wrangling. If there are no dependencies, please send the brcmfmac fixes separately so that I can apply them earlier. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches