From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Shannon Nelson <snelson@pensando.io>,
Richard Cochran <richardcochran@gmail.com>
Cc: netdev@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H . Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
"Christopher S . Hall" <christopher.s.hall@intel.com>
Subject: Re: [RFC PATCH 5/5] PTP: Add support for Intel PMC Timed GPIO Controller
Date: Wed, 17 Jul 2019 09:51:13 +0300 [thread overview]
Message-ID: <87h87l2ly6.fsf@linux.intel.com> (raw)
In-Reply-To: <33864ede-1ce1-92f2-f049-a975060b2743@pensando.io>
Hi,
Shannon Nelson <snelson@pensando.io> writes:
> On 7/16/19 12:20 AM, Felipe Balbi wrote:
>> Add a driver supporting Intel Timed GPIO controller available as part
>> of some Intel PMCs.
>>
>> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
>
> Hi Felipe, just a couple of quick comments:
>
> There are several places where a line is continued on the next line, but
> should be indented to match the opening parenthesis on a function call
> or 'if' expression.
>
> Shouldn't there be a kthread_stop() in intel_pmc_tgpio_remove(), or did
> I miss that somewhere?
Oops :-p
I could've sworn I had added it when disabling the pin. I'll review
that, sure.
--
balbi
next prev parent reply other threads:[~2019-07-17 6:51 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 7:20 [RFC PATCH 0/5] PTP: add support for Intel's TGPIO controller Felipe Balbi
2019-07-16 7:20 ` [RFC PATCH 1/5] x86: tsc: add tsc to art helpers Felipe Balbi
2019-07-16 7:57 ` Thomas Gleixner
2019-08-15 5:57 ` Felipe Balbi
2019-08-15 14:16 ` Thomas Gleixner
2019-10-01 10:24 ` Felipe Balbi
2019-10-17 11:15 ` Thomas Gleixner
2019-10-17 12:01 ` Felipe Balbi
2019-07-16 7:20 ` [RFC PATCH 2/5] PTP: add a callback for counting timestamp events Felipe Balbi
2019-07-16 7:20 ` [RFC PATCH 3/5] PTP: implement PTP_EVENT_COUNT_TSTAMP ioctl Felipe Balbi
2019-07-16 7:20 ` [RFC PATCH 4/5] PTP: Add flag for non-periodic output Felipe Balbi
2019-07-16 16:39 ` Richard Cochran
2019-07-17 6:49 ` Felipe Balbi
2019-07-17 17:36 ` Richard Cochran
2019-07-18 8:59 ` Felipe Balbi
2019-07-18 16:41 ` Richard Cochran
2019-08-13 7:53 ` Felipe Balbi
2019-08-13 17:48 ` Richard Cochran
2019-08-13 18:06 ` Richard Cochran
2019-08-14 7:05 ` Felipe Balbi
2019-07-16 7:20 ` [RFC PATCH 5/5] PTP: Add support for Intel PMC Timed GPIO Controller Felipe Balbi
2019-07-16 19:14 ` Shannon Nelson
2019-07-17 6:51 ` Felipe Balbi [this message]
2019-07-16 16:41 ` [RFC PATCH 0/5] PTP: add support for Intel's TGPIO controller Richard Cochran
2019-07-17 6:52 ` Felipe Balbi
2019-07-17 17:39 ` Richard Cochran
2019-07-18 8:58 ` Felipe Balbi
2019-07-18 19:50 ` Andrew Lunn
2019-07-19 7:35 ` Felipe Balbi
2019-07-19 13:20 ` Andrew Lunn
2019-08-13 7:50 ` Felipe Balbi
2019-08-13 17:49 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h87l2ly6.fsf@linux.intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=bp@alien8.de \
--cc=christopher.s.hall@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=snelson@pensando.io \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).