From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03216C282DA for ; Wed, 17 Apr 2019 22:41:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D0760217FA for ; Wed, 17 Apr 2019 22:41:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387688AbfDQWlf (ORCPT ); Wed, 17 Apr 2019 18:41:35 -0400 Received: from mga17.intel.com ([192.55.52.151]:53152 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725848AbfDQWlf (ORCPT ); Wed, 17 Apr 2019 18:41:35 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2019 15:32:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,363,1549958400"; d="scan'208";a="338479961" Received: from mbhutada-mobl.amr.corp.intel.com (HELO ellie) ([10.255.89.223]) by fmsmga006.fm.intel.com with ESMTP; 17 Apr 2019 15:32:27 -0700 From: Vinicius Costa Gomes To: Jakub Kicinski , davem@davemloft.net Cc: netdev@vger.kernel.org, oss-drivers@netronome.com, Jakub Kicinski , Dirk van der Merwe , Leandro Dorileo Subject: Re: [PATCH net-next 3/5] net/sched: taprio: fix build without 64bit div In-Reply-To: <20190417205159.30938-4-jakub.kicinski@netronome.com> References: <20190417205159.30938-1-jakub.kicinski@netronome.com> <20190417205159.30938-4-jakub.kicinski@netronome.com> Date: Wed, 17 Apr 2019 15:32:26 -0700 Message-ID: <87pnpkl0ud.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, Jakub Kicinski writes: > Recent changes to taprio did not use the correct div64 helpers, > leading to: > > net/sched/sch_taprio.o: In function `taprio_dequeue': > sch_taprio.c:(.text+0x34a): undefined reference to `__divdi3' > net/sched/sch_taprio.o: In function `advance_sched': > sch_taprio.c:(.text+0xa0b): undefined reference to `__divdi3' > net/sched/sch_taprio.o: In function `taprio_init': > sch_taprio.c:(.text+0x1450): undefined reference to `__divdi3' > /home/jkicinski/devel/linux/Makefile:1032: recipe for target 'vmlinux' failed > > Use math64 helpers. > > Fixes: 7b9eba7ba0c1 ("net/sched: taprio: fix picos_per_byte miscalculation") > Signed-off-by: Jakub Kicinski > Reviewed-by: Dirk van der Merwe > --- Acked-by: Vinicius Costa Gomes Cheers, -- Vinicius