From: "Li,Rongqing" <lirongqing@baidu.com>
To: Jakub Kicinski <kuba@kernel.org>,
Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"nhorman@redhat.com" <nhorman@redhat.com>,
"sassmann@redhat.com" <sassmann@redhat.com>,
"jeffrey.t.kirsher@intel.com" <jeffrey.t.kirsher@intel.com>,
Andrew Bowers <andrewx.bowers@intel.com>
Subject: 答复: [net-next 2/6] i40e: prefetch struct page of Rx buffer conditionally
Date: Wed, 29 Jul 2020 06:20:47 +0000 [thread overview]
Message-ID: <8e1471fdcaed4f46825cd8ff112a8c36@baidu.com> (raw)
In-Reply-To: <20200728131423.2430b3f1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
> -----邮件原件-----
> 发件人: Jakub Kicinski [mailto:kuba@kernel.org]
> 发送时间: 2020年7月29日 4:14
> 收件人: Tony Nguyen <anthony.l.nguyen@intel.com>
> 抄送: davem@davemloft.net; Li,Rongqing <lirongqing@baidu.com>;
> netdev@vger.kernel.org; nhorman@redhat.com; sassmann@redhat.com;
> jeffrey.t.kirsher@intel.com; Andrew Bowers <andrewx.bowers@intel.com>
> 主题: Re: [net-next 2/6] i40e: prefetch struct page of Rx buffer conditionally
>
> On Tue, 28 Jul 2020 12:08:38 -0700 Tony Nguyen wrote:
> > From: Li RongQing <lirongqing@baidu.com>
> >
> > page_address() accesses struct page only when WANT_PAGE_VIRTUAL or
> > HASHED_PAGE_VIRTUAL is defined, otherwise it returns address based on
> > offset, so we prefetch it conditionally
> >
> > Signed-off-by: Li RongQing <lirongqing@baidu.com>
> > Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
> > Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> > ---
> > drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c
> > b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
> > index 3e5c566ceb01..5d408fe26063 100644
> > --- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c
> > +++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
> > @@ -1953,7 +1953,9 @@ static struct i40e_rx_buffer
> *i40e_get_rx_buffer(struct i40e_ring *rx_ring,
> > struct i40e_rx_buffer *rx_buffer;
> >
> > rx_buffer = i40e_rx_bi(rx_ring, rx_ring->next_to_clean);
> > +#if defined(WANT_PAGE_VIRTUAL) || defined(HASHED_PAGE_VIRTUAL)
> > prefetchw(rx_buffer->page);
Maybe I change prefetchw to prefetch.
refcount of rx_buffer page will be added here originally,
so prefetchw is needed, but after commit 1793668c3b8c
("i40e/i40evf: Update code to better handle incrementing page count"),
and refcount is not added everytime, so change prefetchw
as prefetch,
> > +#endif
>
> Looks like something that belongs in a common header not (potentially
> multiple) C sources.
Not clear, how should I change?
-Li
next prev parent reply other threads:[~2020-07-29 6:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 19:08 [net-next 0/6][pull request] 40GbE Intel Wired LAN Driver Updates 2020-07-28 Tony Nguyen
2020-07-28 19:08 ` [net-next 1/6] i40e: not compute affinity_mask for IRQ Tony Nguyen
2020-07-28 19:08 ` [net-next 2/6] i40e: prefetch struct page of Rx buffer conditionally Tony Nguyen
2020-07-28 20:14 ` Jakub Kicinski
2020-07-29 6:20 ` Li,Rongqing [this message]
2020-07-29 21:20 ` Jakub Kicinski
2020-07-30 1:15 ` 答复: " Li,Rongqing
2020-07-28 19:08 ` [net-next 3/6] i40e, xsk: remove HW descriptor prefetch in AF_XDP path Tony Nguyen
2020-07-28 19:08 ` [net-next 4/6] i40e: use 16B HW descriptors instead of 32B Tony Nguyen
2020-07-28 19:08 ` [net-next 5/6] i40e, xsk: increase budget for AF_XDP path Tony Nguyen
2020-07-28 20:15 ` Jakub Kicinski
2020-07-29 10:43 ` Björn Töpel
2020-07-29 21:22 ` Jakub Kicinski
2020-07-28 19:08 ` [net-next 6/6] i40e, xsk: move buffer allocation out of the Rx processing loop Tony Nguyen
2020-07-28 20:16 ` [net-next 0/6][pull request] 40GbE Intel Wired LAN Driver Updates 2020-07-28 Jakub Kicinski
2020-08-10 11:47 ` Björn Töpel
2020-08-10 11:51 ` Björn Töpel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e1471fdcaed4f46825cd8ff112a8c36@baidu.com \
--to=lirongqing@baidu.com \
--cc=andrewx.bowers@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).