From: Daniel Borkmann <daniel@iogearbox.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
Alexei Starovoitov <ast@kernel.org>
Subject: Re: [PATCH net-next] netfilter: revert introduction of egress hook
Date: Wed, 18 Mar 2020 10:41:30 +0100 [thread overview]
Message-ID: <97a81974-5063-ed3d-8ad4-9f7ff3aa0908@iogearbox.net> (raw)
In-Reply-To: <20200318093649.sn3hsi7nkd3j34lj@salvia>
On 3/18/20 10:36 AM, Pablo Neira Ayuso wrote:
> On Wed, Mar 18, 2020 at 10:33:22AM +0100, Daniel Borkmann wrote:
>> This reverts the following commits:
>>
>> 8537f78647c0 ("netfilter: Introduce egress hook")
>> 5418d3881e1f ("netfilter: Generalize ingress hook")
>> b030f194aed2 ("netfilter: Rename ingress hook include file")
>>
>> From the discussion in [0], the author's main motivation to add a hook
>> in fast path is for an out of tree kernel module, which is a red flag
>> to begin with. Other mentioned potential use cases like NAT{64,46}
>> is on future extensions w/o concrete code in the tree yet. Revert as
>> suggested [1] given the weak justification to add more hooks to critical
>> fast-path.
>>
>> [0] https://lore.kernel.org/netdev/cover.1583927267.git.lukas@wunner.de/
>> [1] https://lore.kernel.org/netdev/20200318.011152.72770718915606186.davem@davemloft.net/
>>
>> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
>
> Nacked-by: Pablo Neira Ayuso <pablo@netfilter.org>
>
> Daniel, you must be really worried about achieving your goals if you
> have to do politics to block stuff.
Looks like this is your only rationale technical argument you can come
up with?
Thanks,
Daniel
next prev parent reply other threads:[~2020-03-18 9:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 9:33 [PATCH net-next] netfilter: revert introduction of egress hook Daniel Borkmann
2020-03-18 9:36 ` Pablo Neira Ayuso
2020-03-18 9:41 ` Daniel Borkmann [this message]
2020-03-18 9:51 ` Pablo Neira Ayuso
2020-03-18 10:02 ` Florian Westphal
2020-03-18 10:50 ` Daniel Borkmann
2020-03-18 12:33 ` Florian Westphal
2020-03-18 14:22 ` Daniel Borkmann
2020-03-19 1:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97a81974-5063-ed3d-8ad4-9f7ff3aa0908@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).