From: David Laight <David.Laight@ACULAB.COM>
To: 'Tony Nguyen' <anthony.l.nguyen@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>
Cc: Jedrzej Jagielski <jedrzej.jagielski@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"sassmann@redhat.com" <sassmann@redhat.com>,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
Gurucharan G <gurucharanx.g@intel.com>
Subject: RE: [PATCH net 1/5] i40e: Increase delay to 1 s after global EMP reset
Date: Fri, 21 Jan 2022 10:13:26 +0000 [thread overview]
Message-ID: <9fadab3c5fa04310a1171ef7f48c8f88@AcuMS.aculab.com> (raw)
In-Reply-To: <20220121000305.1423587-2-anthony.l.nguyen@intel.com>
From: Tony Nguyen
> Sent: 21 January 2022 00:03
>
> Recently simplified i40e_rebuild causes that FW sometimes
> is not ready after NVM update, the ping does not return.
>
> Increase the delay in case of EMP reset.
> Old delay of 300 ms was introduced for specific cards for 710 series.
> Now it works for all the cards and delay was increased.
...
> + if (test_and_clear_bit(__I40E_EMP_RESET_INTR_RECEIVED, pf->state)) {
> + /* The following delay is necessary for firmware update. */
> + mdelay(1000);
> }
Spinning for a second isn't 'user friendly'.
If there are no locks held you can sleep.
If there are locks held then another cpu can spin waiting for the lock.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2022-01-21 10:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 0:03 [PATCH net 0/5][pull request] Intel Wired LAN Driver Updates 2022-01-20 Tony Nguyen
2022-01-21 0:03 ` [PATCH net 1/5] i40e: Increase delay to 1 s after global EMP reset Tony Nguyen
2022-01-21 10:13 ` David Laight [this message]
2022-01-21 0:03 ` [PATCH net 2/5] i40e: Fix issue when maximum queues is exceeded Tony Nguyen
2022-01-21 0:03 ` [PATCH net 3/5] i40e: Fix queues reservation for XDP Tony Nguyen
2022-01-21 0:03 ` [PATCH net 4/5] i40e: Fix for failed to init adminq while VF reset Tony Nguyen
2022-01-21 0:03 ` [PATCH net 5/5] i40e: fix unsigned stat widths Tony Nguyen
2022-01-21 10:40 ` [PATCH net 0/5][pull request] Intel Wired LAN Driver Updates 2022-01-20 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fadab3c5fa04310a1171ef7f48c8f88@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=anthony.l.nguyen@intel.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=davem@davemloft.net \
--cc=gurucharanx.g@intel.com \
--cc=jedrzej.jagielski@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).