From: Ran Rozenstein <ranro@mellanox.com>
To: Florian Westphal <fw@strlen.de>
Cc: Tariq Toukan <tariqt@mellanox.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Maor Gottlieb <maorg@mellanox.com>,
"edumazet@google.com" <edumazet@google.com>
Subject: RE: [PATCH net-next 0/2] net: ipv4: remove erroneous advancement of list pointer
Date: Wed, 26 Jun 2019 12:48:44 +0000 [thread overview]
Message-ID: <AM4PR0501MB2769CE8DC11EE4A076B62CCCC5E20@AM4PR0501MB2769.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20190625091903.gepfjgpiksslnyqy@breakpoint.cc>
> -----Original Message-----
> From: Florian Westphal [mailto:fw@strlen.de]
> Sent: Tuesday, June 25, 2019 12:19
> To: Ran Rozenstein <ranro@mellanox.com>
> Cc: Tariq Toukan <tariqt@mellanox.com>; Florian Westphal <fw@strlen.de>;
> netdev@vger.kernel.org; Maor Gottlieb <maorg@mellanox.com>;
> edumazet@google.com
> Subject: Re: [PATCH net-next 0/2] net: ipv4: remove erroneous
> advancement of list pointer
>
> Ran Rozenstein <ranro@mellanox.com> wrote:
> > > On 6/17/2019 5:02 PM, Florian Westphal wrote:
> > > > Tariq reported a soft lockup on net-next that Mellanox was able to
> > > > bisect to 2638eb8b50cf ("net: ipv4: provide __rcu annotation for
> ifa_list").
> > > >
> > > > While reviewing above patch I found a regression when addresses
> > > > have a lifetime specified.
> > > >
> > > > Second patch extends rtnetlink.sh to trigger crash (without first
> > > > patch applied).
> > > >
> > >
> > > Thanks Florian.
> > >
> > > Ran, can you please test?
> >
> > Tested, still reproduce.
>
> Can you be a little more specific? Is there any reproducer?
The test dose stress on the interface by running this 2 commands in loop:
command is: /sbin/ip -f inet addr add $IP/16 brd + dev ens8f1
command is: ifconfig ens8f1 $IP netmask 255.255.0.0
when $IP change every iteration.
It execute every second when we see the reproduce somewhere between 40 to 200 seconds of execution.
Thanks,
Ran
next prev parent reply other threads:[~2019-06-26 12:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 14:02 [PATCH net-next 0/2] net: ipv4: remove erroneous advancement of list pointer Florian Westphal
2019-06-17 14:02 ` [PATCH net-next 1/2] " Florian Westphal
2019-06-17 14:02 ` [PATCH net-next 2/2] selftests: rtnetlink: add addresses with fixed life time Florian Westphal
2019-06-17 16:16 ` [PATCH net-next 0/2] net: ipv4: remove erroneous advancement of list pointer Tariq Toukan
2019-06-25 9:04 ` Ran Rozenstein
2019-06-25 9:19 ` Florian Westphal
2019-06-26 12:48 ` Ran Rozenstein [this message]
2019-06-26 20:37 ` Florian Westphal
2019-06-26 23:32 ` Florian Westphal
2019-06-17 23:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM4PR0501MB2769CE8DC11EE4A076B62CCCC5E20@AM4PR0501MB2769.eurprd05.prod.outlook.com \
--to=ranro@mellanox.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=maorg@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).