RE: Patchset - Support for configurable RSS hash key

[Venkata Duvvuru <VenkatKumar.Duvvuru@Emulex.Com>]

> -----Original Message-----
> From: Amir Vadai [mailto:amirv.mellanox@gmail.com] On Behalf Of Amir
> Vadai
> Sent: Sunday, February 02, 2014 9:40 PM
> To: Venkata Duvvuru
> Cc: netdev@vger.kernel.org; Ben Hutchings
> Subject: Re: Patchset - Support for configurable RSS hash key
> 
> On 17/01/14 13:02 +0000, Venkata Duvvuru wrote:
> > NIC drivers that support RSS use either a hard-coded value or a random
> value for the RSS hash key. Irrespective of the type of the key used, the user
> would want to change the hash key if he/she is not satisfied with the
> effectiveness of the default hash-key in spreading the incoming flows evenly
> across the RSS queues.
> >
> > This patch set provides support for configuring the RSS hash-key via the
> ethtool interface.
> >
> > The patch set consists of:
> > a) ethtool user-land patches
> > b) ethtool kernel patch
> > c) be2net patch that implements the ethtool hooks
> 
> Hi,
> 
> I would be happy to add support in setting the hash function in addition to
> the hash key.
> 
> Mellanox NIC's have support in 2 hash functions: Toplitz and XOR.
> 
> Let me if you can add it to your patchset or would like me to send a patch on
> top of yours to add it.

I would prefer you to add the proposed changes on top my patchset. I'm working on the review comments currently and I will post the patchset once the patches are ready.

> 
> Thanks,
> Amir