From: Vasily Khoruzhick <anarsoul@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] Revert "Bluetooth: Align minimum encryption key size for LE and BR/EDR connections"
Date: Thu, 23 May 2019 07:52:43 -0700 [thread overview]
Message-ID: <CA+E=qVfopSA90vG2Kkh+XzdYdNn=M-hJN_AptW=R+B5v3HB9eA@mail.gmail.com> (raw)
In-Reply-To: <7B7F362B-6C8B-4112-8772-FB6BC708ABF5@holtmann.org>
On Wed, May 22, 2019 at 12:08 AM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Vasily,
>
> >> This reverts commit d5bb334a8e171b262e48f378bd2096c0ea458265.
> >>
> >> This commit breaks some HID devices, see [1] for details
> >>
> >> https://bugzilla.kernel.org/show_bug.cgi?id=203643
> >>
> >> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> >> Cc: stable@vger.kernel.org
> >
> > let me have a look at this. Maybe there is a missing initialization for older HID devices that we need to handle. Do you happen to have the full btmon binary trace from controller initialization to connection attempt for me?
> >
> > Are both devices Bluetooth 2.1 or later device that are supporting Secure Simple Pairing? Or is one of them a Bluetooth 2.0 or earlier device?
>
> I am almost certain that you have a Bluetooth 2.0 mouse. I made a really stupid mistake in the key size check logic and forgot to bind it to SSP support. Can you please check the patch that I just send you.
>
> https://lore.kernel.org/linux-bluetooth/20190522070540.48895-1-marcel@holtmann.org/T/#u
This patch fixes the issue for me. Thanks!
>
> Regards
>
> Marcel
>
next prev parent reply other threads:[~2019-05-23 14:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 5:20 [PATCH] Revert "Bluetooth: Align minimum encryption key size for LE and BR/EDR connections" Vasily Khoruzhick
2019-05-22 6:38 ` Marcel Holtmann
2019-05-22 7:08 ` Marcel Holtmann
2019-05-23 14:52 ` Vasily Khoruzhick [this message]
2019-06-11 19:56 ` Vasily Khoruzhick
2019-06-11 21:36 ` Marcel Holtmann
2019-06-12 7:07 ` Greg Kroah-Hartman
2019-06-12 9:38 ` Bastien Nocera
2019-06-12 10:04 ` Johan Hedberg
2019-06-13 7:35 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+E=qVfopSA90vG2Kkh+XzdYdNn=M-hJN_AptW=R+B5v3HB9eA@mail.gmail.com' \
--to=anarsoul@gmail.com \
--cc=davem@davemloft.net \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).