From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Steve Zabele <zabele@comcast.net>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Mark KEATON <mark.keaton@raytheon.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Network Development <netdev@vger.kernel.org>,
"shum@canndrew.org" <shum@canndrew.org>,
"vladimir116@gmail.com" <vladimir116@gmail.com>,
"saifi.khan@strikr.in" <saifi.khan@strikr.in>,
Daniel Borkmann <daniel@iogearbox.net>,
"on2k16nm@gmail.com" <on2k16nm@gmail.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: Is bug 200755 in anyone's queue??
Date: Wed, 4 Sep 2019 11:46:57 -0400 [thread overview]
Message-ID: <CA+FuTSf24VrjOxS9Kg3+DFEYn7ihe6vMj5o7rggOz_6KH_rNpQ@mail.gmail.com> (raw)
In-Reply-To: <F119F197-FD88-4F9B-B064-F23B2E5025A3@comcast.net>
On Wed, Sep 4, 2019 at 10:51 AM Steve Zabele <zabele@comcast.net> wrote:
>
> I think a dual table approach makes a lot of sense here, especially if we look at the different use cases. For the DNS server example, almost certainly there will not be any connected sockets using the server port, so a test of whether the connected table is empty (maybe a boolean stored with the unconnected table?) should get to the existing code very quickly and not require accessing the memory holding the connected table. For our use case, the connected sockets persist for long periods (at network timescales at least) and so any rehashing should be infrequent and so have limited impact on performance overall.
>
> So does a dual table approach seem workable to other folks that know the internals?
Let me take a stab and compare. A dual table does bring it more in
line with how the TCP code is structured.
next prev parent reply other threads:[~2019-09-04 15:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <010601d53bdc$79c86dc0$6d594940$@net>
[not found] ` <20190716070246.0745ee6f@hermes.lan>
2019-08-23 19:02 ` Is bug 200755 in anyone's queue?? Steve Zabele
2019-08-29 19:26 ` Willem de Bruijn
2019-08-30 8:48 ` Steve Zabele
2019-08-30 8:53 ` Steve Zabele
2019-08-30 8:54 ` Eric Dumazet
2019-08-30 20:30 ` Willem de Bruijn
2019-09-03 17:55 ` Willem de Bruijn
2019-09-04 10:28 ` Steve Zabele
2019-09-04 12:00 ` Mark KEATON
2019-09-04 12:23 ` Eric Dumazet
2019-09-04 14:23 ` Willem de Bruijn
2019-09-04 14:51 ` Steve Zabele
2019-09-04 15:46 ` Willem de Bruijn [this message]
2019-09-04 19:26 ` Eric Dumazet
2019-09-10 15:52 ` Willem de Bruijn
2019-09-10 16:56 ` Paolo Abeni
2019-09-10 17:10 ` Willem de Bruijn
2019-08-23 19:04 ` Steve Zabele
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+FuTSf24VrjOxS9Kg3+DFEYn7ihe6vMj5o7rggOz_6KH_rNpQ@mail.gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=daniel@iogearbox.net \
--cc=eric.dumazet@gmail.com \
--cc=mark.keaton@raytheon.com \
--cc=netdev@vger.kernel.org \
--cc=on2k16nm@gmail.com \
--cc=saifi.khan@strikr.in \
--cc=shum@canndrew.org \
--cc=stephen@networkplumber.org \
--cc=vladimir116@gmail.com \
--cc=zabele@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).