From: Victor Nogueira <victor@mojatatu.com>
To: David Ahern <dsahern@gmail.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
Stephen Hemminger <stephen@networkplumber.org>,
netdev@vger.kernel.org, Davide Caratti <dcaratti@redhat.com>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Vlad Buslov <vladbu@nvidia.com>
Subject: Re: [PATCH v2 iproute2-next 00/11] clang warning fixes
Date: Thu, 20 Jan 2022 17:21:35 -0300 [thread overview]
Message-ID: <CA+NMeC_P=d3AN9zg-aAPg2Zq+ZBW8=r2xD+v0FPm=ae8nDegoA@mail.gmail.com> (raw)
In-Reply-To: <b3917b75-9420-c965-e6cf-0dcfeb35b1bd@gmail.com>
On Thu, Jan 20, 2022 at 4:20 PM David Ahern <dsahern@gmail.com> wrote:
>
> On 1/20/22 5:48 AM, Victor Nogueira wrote:
> > Hi,
> > Sorry for not responding sooner. I patched iproute2 and several
> > existing tests failed.
> > Example:
> > Test 696a: Add simple ct action
> >
> > All test results:
> >
> > 1..1
> > not ok 1 696a - Add simple ct action
> > Could not match regex pattern. Verify command output:
> > total acts 1
> >
> > action order 0: ct
> > zone 0 pipe
> > index 42 ref 1 bind 0
> >
> > The problem is the additional new line added.
> >
> > WIthout this patch:
> > https://patchwork.kernel.org/project/netdevbpf/patch/20220117175019.13993-6-stephen@networkplumber.org/
> > it the output of tc actions list action ct is:
> >
> > total acts 1
> >
> > action order 0: ct zone 0 pipe
> > index 42 ref 1 bind 0
> >
> > With it it is:
> >
> > total acts 1
> >
> > action order 0: ct
> > zone 0 pipe
> > index 42 ref 1 bind 0
> >
> > So I believe the problem is just formatting, however it still breaks some tests
> >
>
> Thanks, Victor. Hopefully that is addressed in v3 of the set.
>
Actually, I tested using v3 patches.
Sorry, I should've said that in the previous email.
cheers,
Victor
prev parent reply other threads:[~2022-01-20 20:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 17:54 [PATCH v2 iproute2-next 00/11] clang warning fixes Stephen Hemminger
2022-01-11 17:54 ` [PATCH v2 iproute2-next 01/11] tc: add format attribute to tc_print_rate Stephen Hemminger
2022-01-11 17:54 ` [PATCH v2 iproute2-next 02/11] utils: add format attribute Stephen Hemminger
2022-01-11 17:54 ` [PATCH v2 iproute2-next 03/11] netem: fix clang warnings Stephen Hemminger
2022-01-11 17:54 ` [PATCH v2 iproute2-next 04/11] flower: " Stephen Hemminger
2022-01-11 17:54 ` [PATCH v2 iproute2-next 05/11] tc_util: fix clang warning in print_masked_type Stephen Hemminger
2022-01-11 17:54 ` [PATCH v2 iproute2-next 06/11] ipl2tp: fix clang warning Stephen Hemminger
2022-01-11 17:54 ` [PATCH v2 iproute2-next 07/11] can: " Stephen Hemminger
2022-01-11 17:54 ` [PATCH v2 iproute2-next 08/11] tipc: fix clang warning about empty format string Stephen Hemminger
2022-01-11 17:54 ` [PATCH v2 iproute2-next 09/11] tunnel: fix clang warning Stephen Hemminger
2022-01-11 17:54 ` [PATCH v2 iproute2-next 10/11] libbpf: fix clang warning about format non-literal Stephen Hemminger
2022-01-11 17:54 ` [PATCH v2 iproute2-next 11/11] json_print: suppress clang format warning Stephen Hemminger
2022-01-16 23:18 ` [PATCH v2 iproute2-next 00/11] clang warning fixes David Ahern
2022-01-17 0:33 ` Stephen Hemminger
2022-01-17 15:29 ` Jamal Hadi Salim
2022-01-20 12:48 ` Victor Nogueira
2022-01-20 19:20 ` David Ahern
2022-01-20 20:21 ` Victor Nogueira [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+NMeC_P=d3AN9zg-aAPg2Zq+ZBW8=r2xD+v0FPm=ae8nDegoA@mail.gmail.com' \
--to=victor@mojatatu.com \
--cc=dcaratti@redhat.com \
--cc=dsahern@gmail.com \
--cc=jhs@mojatatu.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=vladbu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).