From: Vladimir Oltean <olteanv@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: dsa: sja1105: Add support for port mirroring
Date: Thu, 3 Oct 2019 22:15:29 +0300 [thread overview]
Message-ID: <CA+h21hoKgFqK6aYErL_dpY+g+-6FzH5vbcuuAZ60Pnev8cn55A@mail.gmail.com> (raw)
In-Reply-To: <20191003.120434.606814989607407144.davem@davemloft.net>
Hi David,
On Thu, 3 Oct 2019 at 22:04, David Miller <davem@davemloft.net> wrote:
>
> From: Vladimir Oltean <olteanv@gmail.com>
> Date: Thu, 3 Oct 2019 02:34:43 +0300
>
> > + already_enabled = (general_params->mirr_port != SJA1105_NUM_PORTS);
> > + if (already_enabled && enabled && general_params->mirr_port != to) {
> > + dev_err(priv->ds->dev,
> > + "Delete mirroring rules towards port %d first", to);
> > + return -EBUSY;
> > + }
>
> In this situation, the user is trying to add a mirror rule to port 'to'
> when we already have rules pointing to "general_params->mirr_port".
>
> So you should be printing out the value of "general_params->mirr_port"
> in this message rather than 'to'.
Good catch, thanks.
-Vladimir
prev parent reply other threads:[~2019-10-03 19:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 23:34 [PATCH net-next] net: dsa: sja1105: Add support for port mirroring Vladimir Oltean
2019-10-03 19:04 ` David Miller
2019-10-03 19:15 ` Vladimir Oltean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+h21hoKgFqK6aYErL_dpY+g+-6FzH5vbcuuAZ60Pnev8cn55A@mail.gmail.com \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).