From: Vladimir Oltean <olteanv@gmail.com>
To: "Allan W. Nielsen" <allan.nielsen@microchip.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Joergen Andreasen <joergen.andreasen@microchip.com>,
Alexandru Marginean <alexandru.marginean@nxp.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
"Y.b. Lu" <yangbo.lu@nxp.com>, netdev <netdev@vger.kernel.org>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH v2 net-next 0/2] Allow unknown unicast traffic to CPU for Felix DSA
Date: Tue, 25 Feb 2020 15:08:40 +0200 [thread overview]
Message-ID: <CA+h21hp41WXXTLZ0L2rwT5b1gMeL5YFBpNpCZMh7d9eWZpmaqw@mail.gmail.com> (raw)
In-Reply-To: <20200225130223.kb7jg7u2kgjjrlpo@lx-anielsen.microsemi.net>
Hi Allan,
On Tue, 25 Feb 2020 at 15:02, Allan W. Nielsen
<allan.nielsen@microchip.com> wrote:
>
> On 24.02.2020 23:34, Vladimir Oltean wrote:
> >From: Vladimir Oltean <vladimir.oltean@nxp.com>
> >
> >This is the continuation of the previous "[PATCH net-next] net: mscc:
> >ocelot: Workaround to allow traffic to CPU in standalone mode":
> >
> >https://www.spinics.net/lists/netdev/msg631067.html
> >
> >Following the feedback received from Allan Nielsen, the Ocelot and Felix
> >drivers were made to use the CPU port module in the same way (patch 1),
> >and Felix was made to additionally allow unknown unicast frames towards
> >the CPU port module (patch 2).
> >
> >Vladimir Oltean (2):
> > net: mscc: ocelot: eliminate confusion between CPU and NPI port
> > net: dsa: felix: Allow unknown unicast traffic towards the CPU port
> > module
> >
> > drivers/net/dsa/ocelot/felix.c | 16 ++++--
> > drivers/net/ethernet/mscc/ocelot.c | 62 +++++++++++++---------
> > drivers/net/ethernet/mscc/ocelot.h | 10 ----
> > drivers/net/ethernet/mscc/ocelot_board.c | 5 +-
> > include/soc/mscc/ocelot.h | 67 ++++++++++++++++++++++--
> > net/dsa/tag_ocelot.c | 3 +-
> > 6 files changed, 117 insertions(+), 46 deletions(-)
>
> Hi Vladimer,
>
> Did this fix you original issue with the spamming of the CPU?
>
> /Allan
No, the entire handling of unknown unicast packets still leaves a lot
to be desired, but at least now the CPU gets those frames, which is
better than it not getting them.
For one thing, an unknown unicast packet received by a standalone
Felix port will still consume CPU cycles dropping it, whereas the same
thing cannot be said for a different DSA switch setup, say a sja1105
switch inheriting the MAC address from the DSA master, because the DSA
master drops that.
Secondly, even traffic that the CPU _intends_ to terminate remains
"unknown" from the switch's perspective, due to the
no-learning-from-injected-traffic issue. So that traffic is still
going to be flooded, potentially to unwanted ports as well.
Regards,
-Vladimir
next prev parent reply other threads:[~2020-02-25 13:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 21:34 [PATCH v2 net-next 0/2] Allow unknown unicast traffic to CPU for Felix DSA Vladimir Oltean
2020-02-24 21:34 ` [PATCH v2 net-next 1/2] net: mscc: ocelot: eliminate confusion between CPU and NPI port Vladimir Oltean
2020-02-25 12:55 ` Allan W. Nielsen
2020-02-24 21:34 ` [PATCH v2 net-next 2/2] net: dsa: felix: Allow unknown unicast traffic towards the CPU port module Vladimir Oltean
2020-02-25 13:01 ` Allan W. Nielsen
2020-02-25 13:02 ` [PATCH v2 net-next 0/2] Allow unknown unicast traffic to CPU for Felix DSA Allan W. Nielsen
2020-02-25 13:08 ` Vladimir Oltean [this message]
2020-02-25 13:37 ` Andrew Lunn
2020-02-25 13:57 ` Vladimir Oltean
2020-02-25 13:43 ` Allan W. Nielsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+h21hp41WXXTLZ0L2rwT5b1gMeL5YFBpNpCZMh7d9eWZpmaqw@mail.gmail.com \
--to=olteanv@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandru.marginean@nxp.com \
--cc=allan.nielsen@microchip.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=joergen.andreasen@microchip.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=xiaoliang.yang_1@nxp.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).