From: Vladimir Oltean <olteanv@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Hubert Feurstein <h.feurstein@gmail.com>,
mlichvar@redhat.com, Richard Cochran <richardcochran@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
linux-spi@vger.kernel.org, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH spi for-5.4 1/5] spi: Use an abbreviated pointer to ctlr->cur_msg in __spi_pump_messages
Date: Tue, 20 Aug 2019 22:36:43 +0300 [thread overview]
Message-ID: <CA+h21hpgi7-dJ-QoRBEQorcRyEuhqhKixpFK5fGxOnZxTHi-4g@mail.gmail.com> (raw)
In-Reply-To: <20190820182128.GH4738@sirena.co.uk>
Hi Mark,
On Tue, 20 Aug 2019 at 21:21, Mark Brown <broonie@kernel.org> wrote:
>
> On Sun, Aug 18, 2019 at 09:25:56PM +0300, Vladimir Oltean wrote:
>
> > /* Extract head of queue */
> > - ctlr->cur_msg =
> > - list_first_entry(&ctlr->queue, struct spi_message, queue);
> > + mesg = list_first_entry(&ctlr->queue, struct spi_message, queue);
> > + ctlr->cur_msg = mesg;
>
> Why mesg when the existing code uses msg as an abbreviation here?
Does it matter? I took from spi_finalize_current_message which also uses mesg.
next prev parent reply other threads:[~2019-08-20 19:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-18 18:25 [PATCH spi for-5.4 0/5] Deterministic SPI latency with NXP DSPI driver Vladimir Oltean
2019-08-18 18:25 ` [PATCH spi for-5.4 1/5] spi: Use an abbreviated pointer to ctlr->cur_msg in __spi_pump_messages Vladimir Oltean
2019-08-20 18:21 ` Mark Brown
2019-08-20 19:36 ` Vladimir Oltean [this message]
2019-08-21 11:01 ` Mark Brown
2019-08-18 18:25 ` [PATCH spi for-5.4 2/5] spi: Add a PTP system timestamp to the transfer structure Vladimir Oltean
2019-08-22 17:11 ` Mark Brown
2019-08-24 12:38 ` Vladimir Oltean
2019-08-27 19:01 ` Mark Brown
2019-08-18 18:25 ` [PATCH spi for-5.4 3/5] spi: spi-fsl-dspi: Use poll mode in case the platform IRQ is missing Vladimir Oltean
2019-08-22 17:38 ` Mark Brown
2019-08-18 18:25 ` [PATCH spi for-5.4 4/5] spi: spi-fsl-dspi: Implement the PTP system timestamping for TCFQ mode Vladimir Oltean
2019-08-18 18:26 ` [PATCH spi for-5.4 5/5] spi: spi-fsl-dspi: Disable interrupts and preemption during poll mode transfer Vladimir Oltean
2019-08-20 15:57 ` [PATCH spi for-5.4 0/5] Deterministic SPI latency with NXP DSPI driver Vladimir Oltean
2019-08-20 16:57 ` Andrew Lunn
2019-08-21 4:38 ` Richard Cochran
2019-08-21 14:08 ` Richard Cochran
2019-08-21 20:17 ` Vladimir Oltean
2019-08-22 14:16 ` Richard Cochran
2019-08-22 14:56 ` Andrew Lunn
2019-08-22 14:58 ` Vladimir Oltean
2019-08-22 16:05 ` Richard Cochran
2019-08-22 16:13 ` Vladimir Oltean
2019-08-23 5:22 ` Richard Cochran
2019-08-24 12:13 ` Vladimir Oltean
2019-08-22 16:10 ` Richard Cochran
2019-08-21 4:42 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+h21hpgi7-dJ-QoRBEQorcRyEuhqhKixpFK5fGxOnZxTHi-4g@mail.gmail.com \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=h.feurstein@gmail.com \
--cc=linux-spi@vger.kernel.org \
--cc=mlichvar@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).