From: Jason Wang <jasowang@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Eugenio Perez Martin <eperezma@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Shannon Nelson <shannon.nelson@amd.com>,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org
Subject: Re: [PATCH] vdpa: reject F_ENABLE_AFTER_DRIVER_OK if backend does not support it
Date: Wed, 5 Jul 2023 15:55:23 +0800 [thread overview]
Message-ID: <CACGkMEvT4Y+-wfhyi324Y5hhAtn+ZF7cP9d=omdH-ZgdJ-4SOQ@mail.gmail.com> (raw)
In-Reply-To: <20230704063646-mutt-send-email-mst@kernel.org>
On Tue, Jul 4, 2023 at 6:38 PM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Tue, Jul 04, 2023 at 12:25:32PM +0200, Eugenio Perez Martin wrote:
> > On Mon, Jul 3, 2023 at 4:52 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> > >
> > > On Mon, Jul 03, 2023 at 04:22:18PM +0200, Eugenio Pérez wrote:
> > > > With the current code it is accepted as long as userland send it.
> > > >
> > > > Although userland should not set a feature flag that has not been
> > > > offered to it with VHOST_GET_BACKEND_FEATURES, the current code will not
> > > > complain for it.
> > > >
> > > > Since there is no specific reason for any parent to reject that backend
> > > > feature bit when it has been proposed, let's control it at vdpa frontend
> > > > level. Future patches may move this control to the parent driver.
> > > >
> > > > Fixes: 967800d2d52e ("vdpa: accept VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK backend feature")
> > > > Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> > >
> > > Please do send v3. And again, I don't want to send "after driver ok" hack
> > > upstream at all, I merged it in next just to give it some testing.
> > > We want RING_ACCESS_AFTER_KICK or some such.
> > >
> >
> > Current devices do not support that semantic.
>
> Which devices specifically access the ring after DRIVER_OK but before
> a kick?
Vhost-net is one example at last. It polls a socket as well, so it
starts to access the ring immediately after DRIVER_OK.
Thanks
>
> > My plan was to convert
> > it in vp_vdpa if needed, and reuse the current vdpa ops. Sorry if I
> > was not explicit enough.
> >
> > The only solution I can see to that is to trap & emulate in the vdpa
> > (parent?) driver, as talked in virtio-comment. But that complicates
> > the architecture:
> > * Offer VHOST_BACKEND_F_RING_ACCESS_AFTER_KICK
> > * Store vq enable state separately, at
> > vdpa->config->set_vq_ready(true), but not transmit that enable to hw
> > * Store the doorbell state separately, but do not configure it to the
> > device directly.
> >
> > But how to recover if the device cannot configure them at kick time,
> > for example?
> >
> > Maybe we can just fail if the parent driver does not support enabling
> > the vq after DRIVER_OK? That way no new feature flag is needed.
> >
> > Thanks!
> >
> > >
> > > > ---
> > > > Sent with Fixes: tag pointing to git.kernel.org/pub/scm/linux/kernel/git/mst
> > > > commit. Please let me know if I should send a v3 of [1] instead.
> > > >
> > > > [1] https://lore.kernel.org/lkml/20230609121244-mutt-send-email-mst@kernel.org/T/
> > > > ---
> > > > drivers/vhost/vdpa.c | 7 +++++--
> > > > 1 file changed, 5 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
> > > > index e1abf29fed5b..a7e554352351 100644
> > > > --- a/drivers/vhost/vdpa.c
> > > > +++ b/drivers/vhost/vdpa.c
> > > > @@ -681,18 +681,21 @@ static long vhost_vdpa_unlocked_ioctl(struct file *filep,
> > > > {
> > > > struct vhost_vdpa *v = filep->private_data;
> > > > struct vhost_dev *d = &v->vdev;
> > > > + const struct vdpa_config_ops *ops = v->vdpa->config;
> > > > void __user *argp = (void __user *)arg;
> > > > u64 __user *featurep = argp;
> > > > - u64 features;
> > > > + u64 features, parent_features = 0;
> > > > long r = 0;
> > > >
> > > > if (cmd == VHOST_SET_BACKEND_FEATURES) {
> > > > if (copy_from_user(&features, featurep, sizeof(features)))
> > > > return -EFAULT;
> > > > + if (ops->get_backend_features)
> > > > + parent_features = ops->get_backend_features(v->vdpa);
> > > > if (features & ~(VHOST_VDPA_BACKEND_FEATURES |
> > > > BIT_ULL(VHOST_BACKEND_F_SUSPEND) |
> > > > BIT_ULL(VHOST_BACKEND_F_RESUME) |
> > > > - BIT_ULL(VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK)))
> > > > + parent_features))
> > > > return -EOPNOTSUPP;
> > > > if ((features & BIT_ULL(VHOST_BACKEND_F_SUSPEND)) &&
> > > > !vhost_vdpa_can_suspend(v))
> > > > --
> > > > 2.39.3
> > >
>
next prev parent reply other threads:[~2023-07-05 7:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 14:22 [PATCH] vdpa: reject F_ENABLE_AFTER_DRIVER_OK if backend does not support it Eugenio Pérez
2023-07-03 14:52 ` Michael S. Tsirkin
2023-07-04 10:25 ` Eugenio Perez Martin
2023-07-04 10:38 ` Michael S. Tsirkin
2023-07-04 11:36 ` Eugenio Perez Martin
2023-07-04 15:45 ` Michael S. Tsirkin
2023-07-05 7:49 ` Jason Wang
2023-07-05 8:41 ` Michael S. Tsirkin
2023-07-06 1:55 ` Jason Wang
2023-07-06 7:05 ` Eugenio Perez Martin
2023-07-06 7:55 ` Jason Wang
2023-07-06 8:03 ` Jason Wang
2023-07-06 9:38 ` Eugenio Perez Martin
2023-07-07 7:57 ` Jason Wang
2023-07-07 10:25 ` Eugenio Perez Martin
2023-07-05 18:27 ` Eugenio Perez Martin
2023-07-06 0:07 ` Shannon Nelson
2023-07-06 6:07 ` Michael S. Tsirkin
2023-07-06 6:35 ` Eugenio Perez Martin
2023-07-06 6:39 ` Michael S. Tsirkin
2023-07-19 22:20 ` Si-Wei Liu
2023-07-19 22:26 ` Michael S. Tsirkin
2023-07-20 0:03 ` Si-Wei Liu
2023-07-05 7:55 ` Jason Wang [this message]
2023-07-05 8:42 ` Michael S. Tsirkin
2023-07-06 1:56 ` Jason Wang
2023-07-06 6:05 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACGkMEvT4Y+-wfhyi324Y5hhAtn+ZF7cP9d=omdH-ZgdJ-4SOQ@mail.gmail.com' \
--to=jasowang@redhat.com \
--cc=eperezma@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=shannon.nelson@amd.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).