From: Soheil Hassas Yeganeh <soheil@google.com>
To: Neal Cardwell <ncardwell@google.com>
Cc: Thomas Higdon <tph@fb.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Jonathan Lemon <jonathan.lemon@gmail.com>,
Dave Jones <dsj@fb.com>, Eric Dumazet <edumazet@google.com>,
Dave Taht <dave.taht@gmail.com>,
Yuchung Cheng <ycheng@google.com>
Subject: Re: [PATCH v5 2/2] tcp: Add snd_wnd to TCP_INFO
Date: Sat, 14 Sep 2019 13:57:26 -0400 [thread overview]
Message-ID: <CACSApvZW3ANwJEpzsY4bxMD1ROiK95j3B-GBkC6T60egvXrHSw@mail.gmail.com> (raw)
In-Reply-To: <CADVnQykBFBU5bFLXRr_aRzxNVpNGQRtELG5kd6viGWqO0uyyng@mail.gmail.com>
On Sat, Sep 14, 2019 at 11:45 AM Neal Cardwell <ncardwell@google.com> wrote:
>
> On Fri, Sep 13, 2019 at 7:23 PM Thomas Higdon <tph@fb.com> wrote:
> >
> > Neal Cardwell mentioned that snd_wnd would be useful for diagnosing TCP
> > performance problems --
> > > (1) Usually when we're diagnosing TCP performance problems, we do so
> > > from the sender, since the sender makes most of the
> > > performance-critical decisions (cwnd, pacing, TSO size, TSQ, etc).
> > > From the sender-side the thing that would be most useful is to see
> > > tp->snd_wnd, the receive window that the receiver has advertised to
> > > the sender.
> >
> > This serves the purpose of adding an additional __u32 to avoid the
> > would-be hole caused by the addition of the tcpi_rcvi_ooopack field.
> >
> > Signed-off-by: Thomas Higdon <tph@fb.com>
> > ---
> > changes since v4:
> > - clarify comment
>
> Acked-by: Neal Cardwell <ncardwell@google.com>
Acked-by: Soheil Hassas Yeganeh <soheil@google.com>
Thank you for adding the new field!
next prev parent reply other threads:[~2019-09-14 17:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 23:23 [PATCH v5 1/2] tcp: Add TCP_INFO counter for packets received out-of-order Thomas Higdon
2019-09-13 23:23 ` [PATCH v5 2/2] tcp: Add snd_wnd to TCP_INFO Thomas Higdon
2019-09-13 23:36 ` Yuchung Cheng
2019-09-14 15:45 ` Neal Cardwell
2019-09-14 17:57 ` Soheil Hassas Yeganeh [this message]
2019-09-16 14:39 ` David Miller
2019-09-14 15:43 ` [PATCH v5 1/2] tcp: Add TCP_INFO counter for packets received out-of-order Neal Cardwell
2019-09-16 17:42 ` Thomas Higdon
2019-09-16 14:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACSApvZW3ANwJEpzsY4bxMD1ROiK95j3B-GBkC6T60egvXrHSw@mail.gmail.com \
--to=soheil@google.com \
--cc=dave.taht@gmail.com \
--cc=dsj@fb.com \
--cc=edumazet@google.com \
--cc=jonathan.lemon@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=tph@fb.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).