netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Jiri Olsa <jolsa@redhat.com>, Julia Kartseva <hex@fb.com>,
	"labbott@redhat.com" <labbott@redhat.com>,
	"acme@kernel.org" <acme@kernel.org>,
	"debian-kernel@lists.debian.org" <debian-kernel@lists.debian.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Andrii Nakryiko <andriin@fb.com>, Andrey Ignatov <rdna@fb.com>,
	Alexei Starovoitov <ast@fb.com>, Yonghong Song <yhs@fb.com>,
	"jolsa@kernel.org" <jolsa@kernel.org>
Subject: Re: libbpf distro packaging
Date: Tue, 13 Aug 2019 11:26:54 -0700	[thread overview]
Message-ID: <CAEf4BzYyj=j=EfkD1jtJm=0fDv+3nYJuDpbaaSumkX-fP7A_fg@mail.gmail.com> (raw)
In-Reply-To: <eb5cf65a-1aa0-fde4-e726-41a736cb7314@iogearbox.net>

On Tue, Aug 13, 2019 at 7:14 AM Daniel Borkmann <daniel@iogearbox.net> wrote:
>
> On 8/13/19 2:24 PM, Jiri Olsa wrote:
> > On Mon, Aug 12, 2019 at 07:04:12PM +0000, Julia Kartseva wrote:
> >> I would like to bring up libbpf publishing discussion started at [1].
> >> The present state of things is that libbpf is built from kernel tree, e.g. [2]
> >> For Debian and [3] for Fedora whereas the better way would be having a
> >> package built from github mirror. The advantages of the latter:
> >> - Consistent, ABI matching versioning across distros
> >> - The mirror has integration tests
> >> - No need in kernel tree to build a package
> >> - Changes can be merged directly to github w/o waiting them to be merged
> >> through bpf-next -> net-next -> main
> >> There is a PR introducing a libbpf.spec which can be used as a starting point: [4]
> >> Any comments regarding the spec itself can be posted there.
> >> In the future it may be used as a source of truth.
> >> Please consider switching libbpf packaging to the github mirror instead
> >> of the kernel tree.
> >> Thanks
> >>
> >> [1] https://lists.iovisor.org/g/iovisor-dev/message/1521
> >> [2] https://packages.debian.org/sid/libbpf4.19
> >> [3] http://rpmfind.net/linux/RPM/fedora/devel/rawhide/x86_64/l/libbpf-5.3.0-0.rc2.git0.1.fc31.x86_64.html
> >> [4] https://github.com/libbpf/libbpf/pull/64
> >
> > hi,
> > Fedora has libbpf as kernel-tools subpackage, so I think
> > we'd need to create new package and deprecate the current
> >
> > but I like the ABI stability by using github .. how's actually
> > the sync (in both directions) with kernel sources going on?
>
> The upstream kernel's tools/lib/bpf/ is always source of truth. Meaning, changes need
> to make it upstream first and they are later synced into the GH stand-alone repo.

As I mentioned in reply to Jiri, kernel's tools/lib/bpf are the source
of truth for the sources of libbpf itself, but Github has some extra
stuff necessary to make libbpf work/build in isolation from kernel.
Plus some administrative stuff (e.g., sync script).

So if this spec is geared towards Github layout and for use with
Github projection of libbpf, maybe it makes more sense to keep it in
Github only? Is that spec going to be useful in kernel sources? Or
will it just create more confusion on why it's there?

Plus it will make it easier to synchronize version bumping/tagging of
new release on Github.

>
> Thanks,
> Daniel

  reply	other threads:[~2019-08-13 18:27 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-12 19:04 libbpf distro packaging Julia Kartseva
2019-08-13 12:24 ` Jiri Olsa
2019-08-13 14:11   ` Daniel Borkmann
2019-08-13 18:26     ` Andrii Nakryiko [this message]
2019-08-13 18:23   ` Andrii Nakryiko
     [not found]     ` <FA139BA4-59E5-43C7-8E72-C7B2FC1C449E@fb.com>
2019-08-20 22:27       ` Julia Kartseva
2019-08-21 21:09         ` Jiri Olsa
2019-08-23  9:22           ` Jiri Olsa
2019-08-23 16:00             ` Alexei Starovoitov
2019-08-26  6:42               ` Jiri Olsa
2019-08-27 22:30                 ` Julia Kartseva
2019-08-28  7:12                   ` Jiri Olsa
2019-09-30 11:13                     ` Jiri Olsa
2019-09-30 18:18                       ` Julia Kartseva
2019-10-03  0:50                         ` Julia Kartseva
2019-10-03 11:10                           ` Jiri Olsa
2019-10-03 16:24                             ` Andrii Nakryiko
2019-10-03 17:29                               ` Jiri Olsa
2019-10-07  0:25                       ` Julia Kartseva
2019-10-08  7:39                         ` Jiri Olsa
2019-10-11 21:14                           ` Julia Kartseva
2019-10-16 10:01                             ` Jiri Olsa
2019-12-19 21:37                               ` Julia Kartseva
2019-12-20 13:58                                 ` Jiri Olsa
2020-03-05  0:22                                   ` Julia Kartseva
2020-03-05 14:18                                     ` Jiri Olsa
2020-03-10 14:57                                       ` Jiri Olsa
2020-03-10 17:18                                         ` Julia Kartseva
2020-03-10 17:49                                           ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEf4BzYyj=j=EfkD1jtJm=0fDv+3nYJuDpbaaSumkX-fP7A_fg@mail.gmail.com' \
    --to=andrii.nakryiko@gmail.com \
    --cc=acme@kernel.org \
    --cc=andriin@fb.com \
    --cc=ast@fb.com \
    --cc=daniel@iogearbox.net \
    --cc=debian-kernel@lists.debian.org \
    --cc=hex@fb.com \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=labbott@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=rdna@fb.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).