From: Drew Fustini <pdp7pdp7@gmail.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Drew Fustini <drew@beagleboard.org>,
netdev@vger.kernel.org,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
Will C <will@macchina.cc>,
menschel.p@posteo.de
Subject: Re: [net-next 6/6] can: mcp251xfd: mcp251xfd_regmap_crc_read(): work around broken CRC on TBC register
Date: Fri, 7 May 2021 15:36:32 -0700 [thread overview]
Message-ID: <CAEf4M_Dg5u=b+fYwXDUMRGSXeXHuo-bXZmzoAs2bW0kFncMSQg@mail.gmail.com> (raw)
In-Reply-To: <20210507072521.3y652xz2kmibjo7d@pengutronix.de>
On Fri, May 7, 2021 at 12:56 AM Marc Kleine-Budde <mkl@pengutronix.de> wrote:
>
> On 22.04.2021 09:18:54, Marc Kleine-Budde wrote:
> > On 4/21/21 9:58 PM, Drew Fustini wrote:
> > > I am encountering similar error with the 5.10 raspberrypi kernel on
> > > RPi 4 with MCP2518FD:
> > >
> > > mcp251xfd spi0.0 can0: CRC read error at address 0x0010 (length=4,
> > > data=00 ad 58 67, CRC=0xbbfd) retrying
> >
> > What's the situation you see these errors?
> >
> > I'm not particular happy with that patch, as it only works around that one
> > particular bit flip issue. If you really hammer the register, the driver will
> > still notice CRC errors that can be explained by other bits flipping. Consider
> > this as the first order approximation of a higher order problem :) - the root
> > cause is still unknown.
> >
> > > Would it be possible for you to pull these patches into a v5.10 branch
> > > in your linux-rpi repo [1]?
> >
> > Here you are:
> >
> > https://github.com/marckleinebudde/linux-rpi/tree/v5.10-rpi/backport-performance-improvements
> >
> > I've included the UINC performance enhancements, too. The branch is compiled
> > tested only, though. I'll send a pull request to the rpi kernel after I've
> > testing feedback from you.
>
> Drew, Patrick, have you tested this branch? If so I'll send a pull
> request to the raspi kernel.
Thank you for following up.
I need to build it and send it to the friend who was testing to check
if the CRC errors go away. He is testing CANFD with a 2021 Ford F150
truck. I will follow up here once I know the results.
-Drew
next prev parent reply other threads:[~2021-05-07 22:36 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 8:01 pull-request: can-next 2021-04-07 Marc Kleine-Budde
2021-04-07 8:01 ` [net-next 1/6] can: skb: alloc_can{,fd}_skb(): set "cf" to NULL if skb allocation fails Marc Kleine-Budde
2021-04-07 8:01 ` [net-next 2/6] can: m_can: m_can_receive_skb(): add missing error handling to can_rx_offload_queue_sorted() call Marc Kleine-Budde
2021-04-07 8:01 ` [net-next 3/6] can: c_can: remove unused enum BOSCH_C_CAN_PLATFORM Marc Kleine-Budde
2021-04-07 8:01 ` [net-next 4/6] can: mcp251xfd: add BQL support Marc Kleine-Budde
2021-04-07 8:01 ` [net-next 5/6] can: mcp251xfd: mcp251xfd_regmap_crc_read_one(): Factor out crc check into separate function Marc Kleine-Budde
2021-04-07 8:01 ` [net-next 6/6] can: mcp251xfd: mcp251xfd_regmap_crc_read(): work around broken CRC on TBC register Marc Kleine-Budde
2021-04-21 19:58 ` Drew Fustini
2021-04-22 7:18 ` Marc Kleine-Budde
2021-04-22 16:46 ` Patrick Menschel
2021-05-07 7:25 ` Marc Kleine-Budde
2021-05-07 8:21 ` Patrick Menschel
2021-05-07 8:25 ` Marc Kleine-Budde
2021-05-08 18:36 ` Patrick Menschel
2021-05-09 7:46 ` Patrick Menschel
2021-05-10 7:45 ` Marc Kleine-Budde
2021-05-20 10:29 ` Patrick Menschel
2021-05-10 7:43 ` Marc Kleine-Budde
2021-12-07 16:53 ` Modilaynen, Pavel
2021-12-08 8:54 ` Marc Kleine-Budde
2021-12-09 10:22 ` Thomas.Kopp
2021-12-09 11:17 ` AW: " Sven Schuchmann
2021-12-09 11:27 ` Marc Kleine-Budde
2021-12-09 12:53 ` AW: " Sven Schuchmann
2021-12-13 22:12 ` Modilaynen, Pavel
2021-12-21 22:24 ` Thomas.Kopp
2022-06-21 14:25 ` Marc Kleine-Budde
2022-06-22 8:19 ` Marc Kleine-Budde
2022-06-22 13:47 ` Thomas.Kopp
2022-06-26 19:14 ` Marc Kleine-Budde
2021-05-07 22:36 ` Drew Fustini [this message]
2021-05-08 12:30 ` Marc Kleine-Budde
2021-04-07 22:10 ` pull-request: can-next 2021-04-07 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEf4M_Dg5u=b+fYwXDUMRGSXeXHuo-bXZmzoAs2bW0kFncMSQg@mail.gmail.com' \
--to=pdp7pdp7@gmail.com \
--cc=drew@beagleboard.org \
--cc=linux-can@vger.kernel.org \
--cc=menschel.p@posteo.de \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=will@macchina.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).