netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
	David Miller <davem@davemloft.net>,
	Realtek linux nic maintainers <nic_swsd@realtek.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v4 net] r8169: work around RTL8125 UDP hw bug
Date: Thu, 28 Jan 2021 17:16:39 -0500	[thread overview]
Message-ID: <CAF=yD-+MdpFQZ8+M5hQaHMODUhAg9FadTm5ck2wu9C=4We9=OA@mail.gmail.com> (raw)
In-Reply-To: <6e453d49-1801-e6de-d5f7-d7e6c7526c8f@gmail.com>

On Thu, Jan 28, 2021 at 5:02 PM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> It was reported that on RTL8125 network breaks under heavy UDP load,
> e.g. torrent traffic ([0], from comment 27). Realtek confirmed a hw bug
> and provided me with a test version of the r8125 driver including a
> workaround. Tests confirmed that the workaround fixes the issue.
> I modified the original version of the workaround to meet mainline
> code style.
>
> [0] https://bugzilla.kernel.org/show_bug.cgi?id=209839
>
> v2:
> - rebased to net
> v3:
> - make rtl_skb_is_udp() more robust and use skb_header_pointer()
>   to access the ip(v6) header
> v4:
> - remove dependency on ptp_classify.h
> - replace magic number with offsetof(struct udphdr, len)
>
> Fixes: f1bce4ad2f1c ("r8169: add support for RTL8125")
> Tested-by: xplo <xplo.bn@gmail.com>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Acked-by: Willem de Bruijn <willemb@google.com>

Thanks for the quick iterations. I was afraid that the switch with
implicit fall-through to the default label could trigger
Wimplicit-fallthrough, but it seems that warning is suppressed if the
case only has a break or return. It's not strictly needed in that
case, but no need to respin just for that, either.

  reply	other threads:[~2021-01-28 22:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-28 22:01 [PATCH v4 net] r8169: work around RTL8125 UDP hw bug Heiner Kallweit
2021-01-28 22:16 ` Willem de Bruijn [this message]
2021-01-30  5:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAF=yD-+MdpFQZ8+M5hQaHMODUhAg9FadTm5ck2wu9C=4We9=OA@mail.gmail.com' \
    --to=willemdebruijn.kernel@gmail.com \
    --cc=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).