From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
Network Development <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
Fred Klassen <fklassen@appneta.com>
Subject: Re: 4.19: udpgso_bench_tx: setsockopt zerocopy: Unknown error 524
Date: Tue, 18 Jun 2019 20:38:19 -0400 [thread overview]
Message-ID: <CAF=yD-JPxx8EQ6ezs5dm+hsXQc8BVTLU8RnMLcw8qYR=OcU8XQ@mail.gmail.com> (raw)
In-Reply-To: <20190618.184409.2227845117139305004.davem@davemloft.net>
On Tue, Jun 18, 2019 at 6:44 PM David Miller <davem@davemloft.net> wrote:
>
> From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
> Date: Tue, 18 Jun 2019 14:58:26 -0400
>
> > I see that in similar such cases that use the test harness
> > (ksft_test_result_skip) the overall test returns success as long as
> > all individual cases return either success or skip.
> >
> > I think it's preferable to return KSFT_SKIP if any of the cases did so
> > (and none returned an error). I'll do that unless anyone objects.
>
> I guess this is a question of semantics.
>
> I mean, if you report skip at the top level does that mean that all
> sub tests were skipped? People may think so... :)
Yes, it's not ideal. Erring on the side of caution? Unlike pass, it is
a signal that an admin may or may not choose to act on. I run a
selected subset of tests from tools/testing that are all expected to
pass, so if one returns skip, I would want to take a closer look.
next prev parent reply other threads:[~2019-06-19 0:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 11:27 4.19: udpgso_bench_tx: setsockopt zerocopy: Unknown error 524 Naresh Kamboju
2019-06-18 12:31 ` Willem de Bruijn
2019-06-18 16:10 ` Greg KH
2019-06-18 16:37 ` Willem de Bruijn
2019-06-18 16:47 ` David Miller
2019-06-18 17:15 ` Greg KH
2019-06-18 17:27 ` Willem de Bruijn
2019-06-18 17:39 ` Greg KH
2019-06-18 18:58 ` Willem de Bruijn
2019-06-18 20:04 ` Willem de Bruijn
2019-06-18 22:44 ` David Miller
2019-06-19 0:38 ` Willem de Bruijn [this message]
2019-06-18 17:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF=yD-JPxx8EQ6ezs5dm+hsXQc8BVTLU8RnMLcw8qYR=OcU8XQ@mail.gmail.com' \
--to=willemdebruijn.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=fklassen@appneta.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).