From: Daniele Palmas <dnlplm@gmail.com>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: Alexander Lobakin <alexandr.lobakin@intel.com>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Subash Abhinov Kasiviswanathan <quic_subashab@quicinc.com>,
Sean Tranchetti <quic_stranche@quicinc.com>,
Jonathan Corbet <corbet@lwn.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] net: qualcomm: rmnet: add tx packets aggregation
Date: Sun, 20 Nov 2022 10:52:26 +0100 [thread overview]
Message-ID: <CAGRyCJFnh8iXBCyzNxzxSp9PBCDxXYDVOfeyojNBGnFtNWniLw@mail.gmail.com> (raw)
In-Reply-To: <87tu2unewg.fsf@miraculix.mork.no>
Il giorno dom 20 nov 2022 alle ore 10:39 Bjørn Mork <bjorn@mork.no> ha scritto:
>
> Daniele Palmas <dnlplm@gmail.com> writes:
>
> > Ok, so rmnet would only take care of qmap rx packets deaggregation and
> > qmi_wwan of the tx aggregation.
> >
> > At a conceptual level, implementing tx aggregation in qmi_wwan for
> > passthrough mode could make sense, since the tx aggregation parameters
> > belong to the physical device and are shared among the virtual rmnet
> > netdevices, which can't have different aggr configurations if they
> > belong to the same physical device.
> >
> > Bjørn, would this approach be ok for you?
>
> Sounds good to me, if this can be done within the userspace API
> restrictions we've been through.
>
> I assume it's possible to make this Just Work(tm) in qmi_wwan
> passthrough mode? I do not think we want any solution where the user
> will have to configure both qmi_wwan and rmnet to make things work
> properly.
>
Yes, I think so: the ethtool configurations would apply to the
qmi_wwan netdevice so that nothing should be done on the rmnet side.
Regards,
Daniele
next prev parent reply other threads:[~2022-11-20 9:52 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 18:02 [PATCH net-next 0/3] add tx packets aggregation to ethtool and rmnet Daniele Palmas
2022-11-09 18:02 ` [PATCH net-next 1/3] ethtool: add tx aggregation parameters Daniele Palmas
2022-11-11 17:07 ` Jakub Kicinski
2022-11-11 21:51 ` Daniele Palmas
2022-11-13 9:48 ` Gal Pressman
2022-11-14 10:06 ` Daniele Palmas
2022-11-14 10:45 ` Dave Taht
2022-11-15 11:51 ` Daniele Palmas
2022-11-15 15:27 ` Dave Taht
2022-11-15 0:42 ` Jakub Kicinski
2022-11-15 10:59 ` Gal Pressman
2022-11-15 16:21 ` Jakub Kicinski
2022-11-09 18:02 ` [PATCH net-next 2/3] net: qualcomm: rmnet: add tx packets aggregation Daniele Palmas
2022-11-10 17:32 ` Alexander Lobakin
2022-11-11 1:17 ` Subash Abhinov Kasiviswanathan (KS)
2022-11-11 17:11 ` Jakub Kicinski
2022-11-11 22:00 ` Daniele Palmas
2022-11-14 8:48 ` Daniele Palmas
2022-11-11 17:23 ` Daniele Palmas
2022-11-16 15:19 ` Daniele Palmas
2022-11-16 16:20 ` Alexander Lobakin
2022-11-20 9:25 ` Daniele Palmas
2022-11-20 9:39 ` Bjørn Mork
2022-11-20 9:52 ` Daniele Palmas [this message]
2022-11-20 17:48 ` Subash Abhinov Kasiviswanathan (KS)
2022-11-21 7:00 ` Daniele Palmas
2022-11-24 3:32 ` Subash Abhinov Kasiviswanathan (KS)
2022-11-10 19:09 ` kernel test robot
2022-11-11 17:14 ` Jakub Kicinski
2022-11-14 9:13 ` Daniele Palmas
2022-11-14 10:25 ` Bjørn Mork
2022-11-15 0:43 ` Jakub Kicinski
2022-11-09 18:02 ` [PATCH net-next 3/3] net: qualcomm: rmnet: add ethtool support for configuring tx aggregation Daniele Palmas
2022-11-11 6:46 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGRyCJFnh8iXBCyzNxzxSp9PBCDxXYDVOfeyojNBGnFtNWniLw@mail.gmail.com \
--to=dnlplm@gmail.com \
--cc=alexandr.lobakin@intel.com \
--cc=bjorn@mork.no \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_stranche@quicinc.com \
--cc=quic_subashab@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).