From: Chen-Yu Tsai <wens@csie.org>
To: Vasily Khoruzhick <anarsoul@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
netdev <netdev@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 2/8] Bluetooth: hci_h5: Add support for reset GPIO
Date: Sat, 19 Jan 2019 01:13:55 +0800 [thread overview]
Message-ID: <CAGb2v665Wsu5dhNi1=-bMmPYP-5nfTamtu0uXVYym+RxzNeN=A@mail.gmail.com> (raw)
In-Reply-To: <20190118170232.16142-3-anarsoul@gmail.com>
On Sat, Jan 19, 2019 at 1:02 AM Vasily Khoruzhick <anarsoul@gmail.com> wrote:
>
> Some boards (e.g. Pine64 and Pinebook) wire a GPIO to reset pin of
> RTL8723BS
Pine64 / Pinebook don't have the enable pin. One could say that the
enable pin and the reset pin you add here are actually the same thing.
ChenYu
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> ---
> drivers/bluetooth/hci_h5.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/bluetooth/hci_h5.c b/drivers/bluetooth/hci_h5.c
> index 069d1c8fde73..7ead8c3d8657 100644
> --- a/drivers/bluetooth/hci_h5.c
> +++ b/drivers/bluetooth/hci_h5.c
> @@ -107,6 +107,7 @@ struct h5 {
> const struct h5_vnd *vnd;
> const char *id;
>
> + struct gpio_desc *reset_gpio;
> struct gpio_desc *enable_gpio;
> struct gpio_desc *device_wake_gpio;
> };
> @@ -833,6 +834,10 @@ static int h5_serdev_probe(struct serdev_device *serdev)
> if (IS_ERR(h5->device_wake_gpio))
> return PTR_ERR(h5->device_wake_gpio);
>
> + h5->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
> + if (IS_ERR(h5->reset_gpio))
> + return PTR_ERR(h5->reset_gpio);
> +
> return hci_uart_register_device(&h5->serdev_hu, &h5p);
> }
>
> @@ -921,6 +926,9 @@ static void h5_btrtl_open(struct h5 *h5)
>
> /* The controller needs up to 500ms to wakeup */
> gpiod_set_value_cansleep(h5->enable_gpio, 1);
> + /* Take it out of reset */
> + gpiod_set_value_cansleep(h5->reset_gpio, 0);
> + msleep(100);
> gpiod_set_value_cansleep(h5->device_wake_gpio, 1);
> msleep(500);
> }
> @@ -928,6 +936,7 @@ static void h5_btrtl_open(struct h5 *h5)
> static void h5_btrtl_close(struct h5 *h5)
> {
> gpiod_set_value_cansleep(h5->device_wake_gpio, 0);
> + gpiod_set_value_cansleep(h5->reset_gpio, 1);
> gpiod_set_value_cansleep(h5->enable_gpio, 0);
> }
>
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-01-18 17:14 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 17:02 [PATCH 0/8] Add support for rtl8723bs/rtl8723cs bluetooth Vasily Khoruzhick
2019-01-18 17:02 ` [PATCH 1/8] Bluetooth: Add new quirk for broken local ext features max_page Vasily Khoruzhick
2019-01-18 17:02 ` [PATCH 2/8] Bluetooth: hci_h5: Add support for reset GPIO Vasily Khoruzhick
2019-01-18 17:13 ` Chen-Yu Tsai [this message]
2019-01-18 17:02 ` [PATCH 3/8] dt-bindings: net: bluetooth: Add rtl8723bs-bluetooth Vasily Khoruzhick
2019-02-18 21:10 ` Rob Herring
2019-02-18 21:24 ` Vasily Khoruzhick
2019-02-18 22:08 ` Stefan Wahren
2019-02-18 22:10 ` Stefan Wahren
2019-02-18 22:28 ` Vasily Khoruzhick
2019-02-19 14:17 ` Rob Herring
2019-02-19 21:09 ` David Summers
2019-02-20 2:59 ` Chen-Yu Tsai
2019-02-22 19:14 ` David Summers
2019-02-22 19:21 ` Vasily Khoruzhick
2019-02-23 20:16 ` David Summers
2019-03-01 20:15 ` Martin Blumenstingl
2019-03-02 9:28 ` 答复: " 陆朱伟
2019-03-02 16:43 ` Martin Blumenstingl
2019-03-04 5:17 ` 答复: " 陆朱伟
2019-02-19 8:56 ` Stefan Wahren
2019-02-19 14:14 ` Rob Herring
2019-02-19 21:25 ` Vasily Khoruzhick
2019-06-02 9:33 ` Luca Weiss
2019-01-18 17:02 ` [PATCH 4/8] Bluetooth: hci_h5: Add support for binding RTL8723BS with device tree Vasily Khoruzhick
2019-01-21 14:44 ` kbuild test robot
2019-01-21 15:09 ` kbuild test robot
2019-01-18 17:02 ` [PATCH 5/8] Bluetooth: btrtl: add support for the RTL8723CS Vasily Khoruzhick
2019-01-21 14:31 ` kbuild test robot
2019-01-18 17:02 ` [PATCH 6/8] arm64: allwinner: a64: enable Bluetooth On Pinebook Vasily Khoruzhick
2019-01-18 17:02 ` [PATCH 7/8] DO-NOT-MERGE: arm64: allwinner: a64: enable Bluetooth On Pine64 Vasily Khoruzhick
2019-01-18 17:02 ` [PATCH 8/8] DO-NOT-MERGE: arm64: allwinner: a64: enable Bluetooth On SoPine baseboard Vasily Khoruzhick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGb2v665Wsu5dhNi1=-bMmPYP-5nfTamtu0uXVYym+RxzNeN=A@mail.gmail.com' \
--to=wens@csie.org \
--cc=anarsoul@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).