From: Sven Van Asbroeck <thesven73@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "Andreas Färber" <afaerber@suse.de>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Enrico Weigelt" <lkml@metux.net>,
"Oliver Hartkopp" <socketcan@hartkopp.net>,
"J. Kiszka" <jan.kiszka@siemens.com>,
"Frank Iwanitz" <friw@hms-networks.de>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH v1 5/5] staging: fieldbus: add support for HMS FL-NET industrial controller
Date: Wed, 2 Oct 2019 11:08:29 -0400 [thread overview]
Message-ID: <CAGngYiXet4-2zUZ0oEO1iOqFM22zgVPZQ24Dzz5Q9TzTOTzjJQ@mail.gmail.com> (raw)
In-Reply-To: <20190930140519.GA2280096@kroah.com>
On Mon, Sep 30, 2019 at 10:09 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> Discussing "patented" in a changelog text is a big no-no. Please don't
> do that. Talk to your corporate lawyers for why not...
Interesting. I will definitely have to investigate what's covered by those
patents.
>
> Why are you adding support for new things here? New hardware support
> should _only_ be added once the code is out of staging, otherwise there
> is no pressure to get it out of this directory structure.
>
Because I am adding configuration support, and the existing supported h/w
does not require this to operate. So I thought it'd make sense to add at
least one in-kernel user of the new config interface.
Would it be a better strategy to add an (optional) config interface to the
existing supported h/w in staging/, rather than introducing new h/w ?
prev parent reply other threads:[~2019-10-02 15:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 18:35 [PATCH v1 0/5] Introduce fieldbus_dev configuration interface Sven Van Asbroeck
2019-09-18 18:35 ` [PATCH v1 1/5] staging: fieldbus core: remove unused strings Sven Van Asbroeck
2019-09-18 18:35 ` [PATCH v1 2/5] staging: fieldbus: move "offline mode" definition to fieldbus core Sven Van Asbroeck
2019-09-18 18:35 ` [PATCH v1 3/5] staging: fieldbus core: add support for device configuration Sven Van Asbroeck
2019-09-30 14:06 ` Greg KH
2019-10-02 15:07 ` Sven Van Asbroeck
2019-10-02 15:23 ` Greg KH
2019-10-02 15:43 ` Sven Van Asbroeck
2019-09-18 18:35 ` [PATCH v1 4/5] staging: fieldbus core: add support for FL-NET devices Sven Van Asbroeck
2019-09-30 14:07 ` Greg KH
2019-10-02 15:08 ` Sven Van Asbroeck
2019-09-18 18:35 ` [PATCH v1 5/5] staging: fieldbus: add support for HMS FL-NET industrial controller Sven Van Asbroeck
2019-09-30 14:05 ` Greg KH
2019-10-02 15:08 ` Sven Van Asbroeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGngYiXet4-2zUZ0oEO1iOqFM22zgVPZQ24Dzz5Q9TzTOTzjJQ@mail.gmail.com \
--to=thesven73@gmail.com \
--cc=afaerber@suse.de \
--cc=friw@hms-networks.de \
--cc=gregkh@linuxfoundation.org \
--cc=jan.kiszka@siemens.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@metux.net \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).