From: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev <netdev@vger.kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <rmk+kernel@armlinux.org.uk>,
Simon Horman <simon.horman@corigine.com>,
Christian Marangi <ansuelsmth@gmail.com>
Subject: Re: [PATCH v2 net-next 3/3] net: phy: marvell: Add support for offloading LED blinking
Date: Mon, 26 Jun 2023 09:03:47 +0530 [thread overview]
Message-ID: <CAH-L+nP7yn5eUBdGWenFNFYctzmebAWX+PgAVk33e=FHiU_Xig@mail.gmail.com> (raw)
In-Reply-To: <20230624205629.4158216-4-andrew@lunn.ch>
[-- Attachment #1.1: Type: text/plain, Size: 11340 bytes --]
On Sun, Jun 25, 2023 at 2:27 AM Andrew Lunn <andrew@lunn.ch> wrote:
> Add the code needed to indicate if a given blinking pattern can be
> offloaded, to offload a pattern and to try to return the current
> pattern. It is expected that ledtrig-netdev will gain support for
> other patterns, such as different link speeds etc. So the code is
> over-engineers to make adding such additional patterns easy.
>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
> drivers/net/phy/marvell.c | 243 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 243 insertions(+)
>
> diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
> index 43b6cb725551..a443df3034f3 100644
> --- a/drivers/net/phy/marvell.c
> +++ b/drivers/net/phy/marvell.c
> @@ -2893,6 +2893,234 @@ static int m88e1318_led_blink_set(struct
> phy_device *phydev, u8 index,
> MII_88E1318S_PHY_LED_FUNC, reg);
> }
>
> +struct marvell_led_rules {
> + int mode;
> + unsigned long rules;
> +};
> +
> +static const struct marvell_led_rules marvell_led0[] = {
> + {
> + .mode = 0,
> + .rules = BIT(TRIGGER_NETDEV_LINK),
> + },
> + {
> + .mode = 3,
> + .rules = (BIT(TRIGGER_NETDEV_RX) |
> + BIT(TRIGGER_NETDEV_TX)),
> + },
> + {
> + .mode = 4,
> + .rules = (BIT(TRIGGER_NETDEV_RX) |
> + BIT(TRIGGER_NETDEV_TX)),
> + },
> + {
> + .mode = 5,
> + .rules = BIT(TRIGGER_NETDEV_TX),
> + },
> + {
> + .mode = 8,
> + .rules = 0,
> + },
> +};
> +
> +static const struct marvell_led_rules marvell_led1[] = {
> + {
> + .mode = 1,
> + .rules = (BIT(TRIGGER_NETDEV_LINK) |
> + BIT(TRIGGER_NETDEV_RX) |
> + BIT(TRIGGER_NETDEV_TX)),
> + },
> + {
> + .mode = 2,
> + .rules = (BIT(TRIGGER_NETDEV_LINK) |
> + BIT(TRIGGER_NETDEV_RX)),
> + },
> + {
> + .mode = 3,
> + .rules = (BIT(TRIGGER_NETDEV_RX) |
> + BIT(TRIGGER_NETDEV_TX)),
> + },
> + {
> + .mode = 4,
> + .rules = (BIT(TRIGGER_NETDEV_RX) |
> + BIT(TRIGGER_NETDEV_TX)),
> + },
> + {
> + .mode = 8,
> + .rules = 0,
> + },
> +};
> +
> +static const struct marvell_led_rules marvell_led2[] = {
> + {
> + .mode = 0,
> + .rules = BIT(TRIGGER_NETDEV_LINK),
> + },
> + {
> + .mode = 1,
> + .rules = (BIT(TRIGGER_NETDEV_LINK) |
> + BIT(TRIGGER_NETDEV_RX) |
> + BIT(TRIGGER_NETDEV_TX)),
> + },
> + {
> + .mode = 3,
> + .rules = (BIT(TRIGGER_NETDEV_RX) |
> + BIT(TRIGGER_NETDEV_TX)),
> + },
> + {
> + .mode = 4,
> + .rules = (BIT(TRIGGER_NETDEV_RX) |
> + BIT(TRIGGER_NETDEV_TX)),
> + },
> + {
> + .mode = 5,
> + .rules = BIT(TRIGGER_NETDEV_TX),
> + },
> + {
> + .mode = 8,
> + .rules = 0,
> + },
> +};
> +
> +static int marvell_find_led_mode(unsigned long rules,
> + const struct marvell_led_rules
> *marvell_rules,
> + int count,
> + int *mode)
> +{
> + int i;
> +
> + for (i = 0; i < count; i++) {
> + if (marvell_rules[i].rules == rules) {
> + *mode = marvell_rules[i].mode;
> + return 0;
> + }
> + }
> + return -EOPNOTSUPP;
> +}
> +
> +static int marvell_get_led_mode(u8 index, unsigned long rules, int *mode)
> +{
> + int ret;
> +
> + switch (index) {
> + case 0:
> + ret = marvell_find_led_mode(rules, marvell_led0,
> + ARRAY_SIZE(marvell_led0),
> mode);
> + break;
>
[Kalesh]: If you return directly from here, you can avoid the "return ret;"
at the end of this function. Also, it will make other cases in sync with
the default one.
> + case 1:
> + ret = marvell_find_led_mode(rules, marvell_led1,
> + ARRAY_SIZE(marvell_led1),
> mode);
> + break;
> + case 2:
> + ret = marvell_find_led_mode(rules, marvell_led2,
> + ARRAY_SIZE(marvell_led2),
> mode);
> + break;
> + default:
> + return -EINVAL;
> + }
> +
> + return ret;
> +}
> +
> +static int marvell_find_led_rules(unsigned long *rules,
> + const struct marvell_led_rules
> *marvell_rules,
> + int count,
> + int mode)
> +{
> + int i;
> +
> + for (i = 0; i < count; i++) {
> + if (marvell_rules[i].mode == mode) {
> + *rules = marvell_rules[i].rules;
> + return 0;
> + }
> + }
> + return -EOPNOTSUPP;
> +}
> +
> +static int marvell_get_led_rules(u8 index, unsigned long *rules, int mode)
> +{
> + int ret;
> +
> + switch (index) {
> + case 0:
> + ret = marvell_find_led_rules(rules, marvell_led0,
> + ARRAY_SIZE(marvell_led0),
> mode);
> + break;
> + case 1:
> + ret = marvell_find_led_rules(rules, marvell_led1,
> + ARRAY_SIZE(marvell_led1),
> mode);
> + break;
> + case 2:
> + ret = marvell_find_led_rules(rules, marvell_led2,
> + ARRAY_SIZE(marvell_led2),
> mode);
> + break;
> + default:
> + return -EOPNOTSUPP;
> + }
> +
> + return ret;
> +}
> +
> +static int m88e1318_led_hw_is_supported(struct phy_device *phydev, u8
> index,
> + unsigned long rules)
> +{
> + int mode, ret;
> +
> + switch (index) {
> + case 0:
> + case 1:
> + case 2:
> + ret = marvell_get_led_mode(index, rules, &mode);
> + break;
> + default:
> + ret = -EINVAL;
> + }
> +
> + return ret;
> +}
> +
> +static int m88e1318_led_hw_control_set(struct phy_device *phydev, u8
> index,
> + unsigned long rules)
> +{
> + int mode, ret, reg;
> +
> + switch (index) {
> + case 0:
> + case 1:
> + case 2:
> + ret = marvell_get_led_mode(index, rules, &mode);
> + break;
> + default:
> + ret = -EINVAL;
> + }
> +
> + if (ret < 0)
> + return ret;
> +
> + reg = phy_read_paged(phydev, MII_MARVELL_LED_PAGE,
> + MII_88E1318S_PHY_LED_FUNC);
>
[Kalesh]: Don't you need a check here for "reg < 0"?
> + reg &= ~(0xf << (4 * index));
> + reg |= mode << (4 * index);
> + return phy_write_paged(phydev, MII_MARVELL_LED_PAGE,
> + MII_88E1318S_PHY_LED_FUNC, reg);
> +}
> +
> +static int m88e1318_led_hw_control_get(struct phy_device *phydev, u8
> index,
> + unsigned long *rules)
> +{
> + int mode, reg;
> +
> + if (index > 2)
> + return -EINVAL;
> +
> + reg = phy_read_paged(phydev, MII_MARVELL_LED_PAGE,
> + MII_88E1318S_PHY_LED_FUNC);
> + mode = (reg >> (4 * index)) & 0xf;
> +
> + return marvell_get_led_rules(index, rules, mode);
> +}
> +
> static int marvell_probe(struct phy_device *phydev)
> {
> struct marvell_priv *priv;
> @@ -3144,6 +3372,9 @@ static struct phy_driver marvell_drivers[] = {
> .get_stats = marvell_get_stats,
> .led_brightness_set = m88e1318_led_brightness_set,
> .led_blink_set = m88e1318_led_blink_set,
> + .led_hw_is_supported = m88e1318_led_hw_is_supported,
> + .led_hw_control_set = m88e1318_led_hw_control_set,
> + .led_hw_control_get = m88e1318_led_hw_control_get,
> },
> {
> .phy_id = MARVELL_PHY_ID_88E1145,
> @@ -3252,6 +3483,9 @@ static struct phy_driver marvell_drivers[] = {
> .cable_test_get_status =
> marvell_vct7_cable_test_get_status,
> .led_brightness_set = m88e1318_led_brightness_set,
> .led_blink_set = m88e1318_led_blink_set,
> + .led_hw_is_supported = m88e1318_led_hw_is_supported,
> + .led_hw_control_set = m88e1318_led_hw_control_set,
> + .led_hw_control_get = m88e1318_led_hw_control_get,
> },
> {
> .phy_id = MARVELL_PHY_ID_88E1540,
> @@ -3280,6 +3514,9 @@ static struct phy_driver marvell_drivers[] = {
> .cable_test_get_status =
> marvell_vct7_cable_test_get_status,
> .led_brightness_set = m88e1318_led_brightness_set,
> .led_blink_set = m88e1318_led_blink_set,
> + .led_hw_is_supported = m88e1318_led_hw_is_supported,
> + .led_hw_control_set = m88e1318_led_hw_control_set,
> + .led_hw_control_get = m88e1318_led_hw_control_get,
> },
> {
> .phy_id = MARVELL_PHY_ID_88E1545,
> @@ -3308,6 +3545,9 @@ static struct phy_driver marvell_drivers[] = {
> .cable_test_get_status =
> marvell_vct7_cable_test_get_status,
> .led_brightness_set = m88e1318_led_brightness_set,
> .led_blink_set = m88e1318_led_blink_set,
> + .led_hw_is_supported = m88e1318_led_hw_is_supported,
> + .led_hw_control_set = m88e1318_led_hw_control_set,
> + .led_hw_control_get = m88e1318_led_hw_control_get,
> },
> {
> .phy_id = MARVELL_PHY_ID_88E3016,
> @@ -3451,6 +3691,9 @@ static struct phy_driver marvell_drivers[] = {
> .set_tunable = m88e1540_set_tunable,
> .led_brightness_set = m88e1318_led_brightness_set,
> .led_blink_set = m88e1318_led_blink_set,
> + .led_hw_is_supported = m88e1318_led_hw_is_supported,
> + .led_hw_control_set = m88e1318_led_hw_control_set,
> + .led_hw_control_get = m88e1318_led_hw_control_get,
> },
> };
>
> --
> 2.40.1
>
>
>
--
Regards,
Kalesh A P
[-- Attachment #1.2: Type: text/html, Size: 14484 bytes --]
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4239 bytes --]
next prev parent reply other threads:[~2023-06-26 3:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-24 20:56 [PATCH v2 net-next 0/3] Support offload LED blinking to PHY Andrew Lunn
2023-06-24 20:56 ` [PATCH v2 net-next 1/3] led: trig: netdev: Fix requesting offload device Andrew Lunn
2023-07-18 19:34 ` Daniel Golle
2023-08-07 22:27 ` Andrew Lunn
2023-08-07 22:49 ` Daniel Golle
2023-08-07 23:48 ` Andrew Lunn
2023-06-24 20:56 ` [PATCH v2 net-next 2/3] net: phy: phy_device: Call into the PHY driver to set LED offload Andrew Lunn
2023-06-24 20:56 ` [PATCH v2 net-next 3/3] net: phy: marvell: Add support for offloading LED blinking Andrew Lunn
2023-06-26 3:33 ` Kalesh Anakkur Purayil [this message]
2023-07-29 12:38 ` [PATCH v2 net-next 0/3] Support offload LED blinking to PHY Daniel Golle
2023-07-29 17:19 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH-L+nP7yn5eUBdGWenFNFYctzmebAWX+PgAVk33e=FHiU_Xig@mail.gmail.com' \
--to=kalesh-anakkur.purayil@broadcom.com \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).