From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Chen Zhou <chenzhou10@huawei.com>
Cc: davem@davemloft.net, jiri@mellanox.com, krzk@kernel.org,
gregkh@linuxfoundation.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] drivers: net: WIREGUARD depends on IPV6
Date: Tue, 25 Feb 2020 14:52:47 +0800 [thread overview]
Message-ID: <CAHmME9rWq+jJk5s+OoQ+MFMg74=b-a+LtJFjNWqLg6fcreLKbA@mail.gmail.com> (raw)
In-Reply-To: <20200225063930.106436-1-chenzhou10@huawei.com>
On 2/25/20, Chen Zhou <chenzhou10@huawei.com> wrote:
> If CONFIG_IPV6 is n, build fails:
>
> drivers/net/wireguard/device.o: In function `wg_xmit':
> device.c:(.text+0xb2d): undefined reference to `icmpv6_ndo_send'
> make: *** [vmlinux] Error 1
>
> Set WIREGUARD depending on IPV6 to fix this.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> ---
> drivers/net/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 25a8f93..824292e 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -74,7 +74,7 @@ config DUMMY
> config WIREGUARD
> tristate "WireGuard secure network tunnel"
> depends on NET && INET
> - depends on IPV6 || !IPV6
> + depends on IPV6
Thanks for reporting the breakage. However, this is not the correct
fix, as wireguard should work without IPv6. Rather, the recent icmp
fixes changed something. I'll investigate why when I'm off the road in
several hours.
next prev parent reply other threads:[~2020-02-25 6:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 6:39 [PATCH -next] drivers: net: WIREGUARD depends on IPV6 Chen Zhou
2020-02-25 6:52 ` Jason A. Donenfeld [this message]
2020-02-25 10:08 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHmME9rWq+jJk5s+OoQ+MFMg74=b-a+LtJFjNWqLg6fcreLKbA@mail.gmail.com' \
--to=jason@zx2c4.com \
--cc=chenzhou10@huawei.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=jiri@mellanox.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).