From: Eyal Birger <eyal.birger@gmail.com>
To: Sabrina Dubroca <sd@queasysnail.net>
Cc: Steffen Klassert <steffen.klassert@secunet.com>,
herbert@gondor.apana.org.au, David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [PATCH ipsec,v2] xfrm: interface: fix ipv4 pmtu check to honor ip header df
Date: Tue, 23 Feb 2021 17:37:14 +0200 [thread overview]
Message-ID: <CAHsH6Gs2=siz4a4CZAe3NDnKuhZKQDRk-kbB2ZdGjM1w9c2njQ@mail.gmail.com> (raw)
In-Reply-To: <YDUbYvCnRN/aBQrM@hog>
Hi,
On Tue, Feb 23, 2021 at 5:18 PM Sabrina Dubroca <sd@queasysnail.net> wrote:
>
> 2021-02-20, 15:01:15 +0200, Eyal Birger wrote:
> > Frag needed should only be sent if the header enables DF.
> >
> > This fix allows packets larger than MTU to pass the xfrm interface
> > and be fragmented after encapsulation, aligning behavior with
> > non-interface xfrm.
> >
> > Fixes: f203b76d7809 ("xfrm: Add virtual xfrm interfaces")
> > Signed-off-by: Eyal Birger <eyal.birger@gmail.com>
> >
> > -----
> >
> > v2: better align coding with ip_vti
>
> LGTM. We also need to do the same thing in ip_vti and ip6_vti. Do you
> want to take care of it, or should I?
I can submit the same fix for vti{,6}.
>
> Either way, for this patch:
> Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
Thanks!
Eyal.
next prev parent reply other threads:[~2021-02-23 15:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 17:21 [PATCH ipsec] xfrm: interface: fix ipv4 pmtu check to honor ip header df Eyal Birger
2021-02-20 13:01 ` [PATCH ipsec,v2] " Eyal Birger
2021-02-23 15:12 ` Sabrina Dubroca
2021-02-23 15:24 ` Bram Yvahk
2021-02-23 15:37 ` Eyal Birger [this message]
2021-02-23 17:26 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHsH6Gs2=siz4a4CZAe3NDnKuhZKQDRk-kbB2ZdGjM1w9c2njQ@mail.gmail.com' \
--to=eyal.birger@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).