From: Roopa Prabhu <roopa@cumulusnetworks.com>
To: Donald Sharp <sharpd@cumulusnetworks.com>
Cc: netdev <netdev@vger.kernel.org>, David Ahern <dsahern@kernel.org>
Subject: Re: [PATCH] ip route: Do not imply pref and ttl-propagate are per nexthop
Date: Fri, 28 Feb 2020 10:54:44 -0800 [thread overview]
Message-ID: <CAJieiUgj5Ho+_OndvVN1a40Fc_4z+BFwwY_hwOJjpb0H7K0oAQ@mail.gmail.com> (raw)
In-Reply-To: <20200225131213.2709230-1-sharpd@cumulusnetworks.com>
On Tue, Feb 25, 2020 at 5:12 AM Donald Sharp <sharpd@cumulusnetworks.com> wrote:
>
> Currently `ip -6 route show` gives us this output:
>
> sharpd@eva ~/i/ip (master)> ip -6 route show
> ::1 dev lo proto kernel metric 256 pref medium
> 4:5::6:7 nhid 18 proto static metric 20
> nexthop via fe80::99 dev enp39s0 weight 1
> nexthop via fe80::44 dev enp39s0 weight 1 pref medium
>
> Displaying `pref medium` as the last bit of output implies
> that the RTA_PREF is a per nexthop value, when it is infact
> a per route piece of data.
>
> Change the output to display RTA_PREF and RTA_TTL_PROPAGATE
> before the RTA_MULTIPATH data is shown:
>
> sharpd@eva ~/i/ip (master)> ./ip -6 route show
> ::1 dev lo proto kernel metric 256 pref medium
> 4:5::6:7 nhid 18 proto static metric 20 pref medium
> nexthop via fe80::99 dev enp39s0 weight 1
> nexthop via fe80::44 dev enp39s0 weight 1
>
> Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Acked-by: Roopa Prabhu <roopa@cumulusnetworks.com>
> ---
> ip/iproute.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/ip/iproute.c b/ip/iproute.c
> index 93b805c9..07c45169 100644
> --- a/ip/iproute.c
> +++ b/ip/iproute.c
> @@ -933,9 +933,6 @@ int print_route(struct nlmsghdr *n, void *arg)
> if (tb[RTA_IIF] && filter.iifmask != -1)
> print_rta_if(fp, tb[RTA_IIF], "iif");
>
> - if (tb[RTA_MULTIPATH])
> - print_rta_multipath(fp, r, tb[RTA_MULTIPATH]);
> -
> if (tb[RTA_PREF])
> print_rt_pref(fp, rta_getattr_u8(tb[RTA_PREF]));
>
> @@ -951,6 +948,14 @@ int print_route(struct nlmsghdr *n, void *arg)
> propagate ? "enabled" : "disabled");
> }
>
> + if (tb[RTA_MULTIPATH])
> + print_rta_multipath(fp, r, tb[RTA_MULTIPATH]);
> +
> + /* If you are adding new route RTA_XXXX then place it above
> + * the RTA_MULTIPATH else it will appear that the last nexthop
> + * in the ECMP has new attributes
> + */
> +
> print_string(PRINT_FP, NULL, "\n", NULL);
> close_json_object();
> fflush(fp);
> --
> 2.25.0
>
next prev parent reply other threads:[~2020-02-28 18:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 13:12 [PATCH] ip route: Do not imply pref and ttl-propagate are per nexthop Donald Sharp
2020-02-28 18:30 ` Andrea Claudi
2020-02-28 18:54 ` Roopa Prabhu [this message]
2020-02-28 21:47 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJieiUgj5Ho+_OndvVN1a40Fc_4z+BFwwY_hwOJjpb0H7K0oAQ@mail.gmail.com \
--to=roopa@cumulusnetworks.com \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sharpd@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).