From: Stanislav Fomichev <sdf@google.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com
Subject: Re: [PATCH net] netlink: specs: correct types of legacy arrays
Date: Fri, 26 May 2023 16:15:10 -0700 [thread overview]
Message-ID: <CAKH8qBtTDi+0dgrn=OfCDrbVSAKZN0ktcnSddS=sV518R-dx-w@mail.gmail.com> (raw)
In-Reply-To: <20230526220653.65538-1-kuba@kernel.org>
On Fri, May 26, 2023 at 3:07 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> ethtool has some attrs which dump multiple scalars into
> an attribute. The spec currently expects one attr per entry.
>
> Fixes: a353318ebf24 ("tools: ynl: populate most of the ethtool spec")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: Stanislav Fomichev <sdf@google.com>
> ---
> CC: sdf@google.com
> ---
> Documentation/netlink/specs/ethtool.yaml | 32 ++++++------------------
> 1 file changed, 8 insertions(+), 24 deletions(-)
>
> diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
> index 129f413ea349..3abc576ff797 100644
> --- a/Documentation/netlink/specs/ethtool.yaml
> +++ b/Documentation/netlink/specs/ethtool.yaml
> @@ -60,22 +60,6 @@ doc: Partial family for Ethtool Netlink.
> type: nest
> nested-attributes: bitset-bits
>
> - -
> - name: u64-array
> - attributes:
> - -
> - name: u64
> - type: nest
> - multi-attr: true
> - nested-attributes: u64
> - -
> - name: s32-array
> - attributes:
> - -
> - name: s32
> - type: nest
> - multi-attr: true
> - nested-attributes: s32
> -
> name: string
> attributes:
> @@ -705,16 +689,16 @@ doc: Partial family for Ethtool Netlink.
> type: u8
> -
> name: corrected
> - type: nest
> - nested-attributes: u64-array
> + type: binary
> + sub-type: u64
> -
> name: uncorr
> - type: nest
> - nested-attributes: u64-array
> + type: binary
> + sub-type: u64
> -
> name: corr-bits
> - type: nest
> - nested-attributes: u64-array
> + type: binary
> + sub-type: u64
> -
> name: fec
> attributes:
> @@ -827,8 +811,8 @@ doc: Partial family for Ethtool Netlink.
> type: u32
> -
> name: index
> - type: nest
> - nested-attributes: s32-array
> + type: binary
> + sub-type: s32
> -
> name: module
> attributes:
> --
> 2.40.1
>
next prev parent reply other threads:[~2023-05-26 23:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 22:06 [PATCH net] netlink: specs: correct types of legacy arrays Jakub Kicinski
2023-05-26 23:15 ` Stanislav Fomichev [this message]
2023-05-30 5:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKH8qBtTDi+0dgrn=OfCDrbVSAKZN0ktcnSddS=sV518R-dx-w@mail.gmail.com' \
--to=sdf@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).