From: Cong Wang <xiyou.wangcong@gmail.com>
To: Martin Olsson <martin.olsson+netdev@sentorsecurity.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: tc - mirred ingress not supported at the moment
Date: Wed, 14 Aug 2019 13:51:27 -0700 [thread overview]
Message-ID: <CAM_iQpXNVgpi0+4BHw6zDN3z=dRpERqr6+ohjytf=zKoLd+CLg@mail.gmail.com> (raw)
In-Reply-To: <CAAT+qEYG5=5ny+t0VcqiYjDUQLrcj9sBR=2w-fdsE7Jjf4xOkQ@mail.gmail.com>
On Wed, Aug 14, 2019 at 2:02 AM Martin Olsson
<martin.olsson+netdev@sentorsecurity.com> wrote:
>
> Hi Cong!
>
> Ah sorry.
> Already implemented. Great!
>
> Hmmm. Then why don't the manual at https://www.linux.org/docs/man8/tc-mirred.html to reflect the changes?
> That was the place I checked to see if ingress was still not implemented.
> In the commit you point at, the sentence "Currently only egress is implemented" has been removed.
This means that website is out-of-date, not sync'ed with latest man pages.
>
>
> Question:
> Is there any form of performance penalty if I send the mirrored traffic to the ingress queue of the destination interface rather than to the egress queue?
> I mean, in the kernel there is the possibility to perform far more actions on the ingress queue than on the egress, but if I leave both queues at their defaults, will mirrored packets to ingress use more CPU cycles than to the egress destination, or are they more or less identical?
>
Hard to say without measurement. There is no queue on ingress
side, by the way, so it could be faster than egress, regarding to
lock contentions on queues.
>
> Question 2:
> Given the commit https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=5eca0a3701223619a513c7209f7d9335ca1b4cfa, how can I see in what kernel version it was added?
>
The kernel commit is:
commit 53592b3640019f2834701093e38272fdfd367ad8
Author: Shmulik Ladkani <shmulik.ladkani@gmail.com>
Date: Thu Oct 13 09:06:44 2016 +0300
net/sched: act_mirred: Implement ingress actions
which is merged in 4.10.
Thanks.
prev parent reply other threads:[~2019-08-14 20:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAAT+qEa6Yw-tf3L_R-phzSvLiGOdW9uLhFGNTz+i9eWhBT_+DA@mail.gmail.com>
2019-08-13 10:51 ` tc - mirred ingress not supported at the moment Martin Olsson
2019-08-13 16:47 ` Cong Wang
[not found] ` <CAAT+qEYG5=5ny+t0VcqiYjDUQLrcj9sBR=2w-fdsE7Jjf4xOkQ@mail.gmail.com>
2019-08-14 9:25 ` Martin Olsson
2019-08-14 16:14 ` Stephen Hemminger
2019-08-14 20:51 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM_iQpXNVgpi0+4BHw6zDN3z=dRpERqr6+ohjytf=zKoLd+CLg@mail.gmail.com' \
--to=xiyou.wangcong@gmail.com \
--cc=martin.olsson+netdev@sentorsecurity.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).