From: Geert Uytterhoeven <geert@linux-m68k.org>
To: kernel test robot <lkp@intel.com>
Cc: Sharath Chandra Vurukala <sharathv@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
elder@kernel.org, cpratapa@codeaurora.org,
subashab@codeaurora.org, netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kbuild-all@lists.01.org
Subject: Re: [PATCH net-next v2 2/3] net: ethernet: rmnet: Support for downlink MAPv5 checksum offload
Date: Tue, 23 Feb 2021 11:52:24 +0100 [thread overview]
Message-ID: <CAMuHMdUTVaRSEt2a_sJSEYX0TCH73xspSXkd--=913dpeSzv0Q@mail.gmail.com> (raw)
In-Reply-To: <202102230358.bmAq2nwP-lkp@intel.com>
Hi Kernel Test Robot,
On Mon, Feb 22, 2021 at 10:02 PM kernel test robot <lkp@intel.com> wrote:
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on net-next/master]
>
> url: https://github.com/0day-ci/linux/commits/Sharath-Chandra-Vurukala/net-qualcomm-rmnet-Enable-Mapv5/20210223-010109
> base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git d310ec03a34e92a77302edb804f7d68ee4f01ba0
> config: m68k-allmodconfig (attached as .config)
> compiler: m68k-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/0day-ci/linux/commit/a96da20e1028049cc3824b52bb5293376c0868ce
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Sharath-Chandra-Vurukala/net-qualcomm-rmnet-Enable-Mapv5/20210223-010109
> git checkout a96da20e1028049cc3824b52bb5293376c0868ce
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> In file included from include/linux/kernel.h:10,
> from include/linux/list.h:9,
> from include/linux/timer.h:5,
> from include/linux/netdevice.h:24,
> from drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c:7:
> include/linux/scatterlist.h: In function 'sg_set_buf':
> arch/m68k/include/asm/page_mm.h:174:49: warning: ordered comparison of pointer with null pointer [-Wextra]
> 174 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
> | ^~
> include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
> 78 | # define unlikely(x) __builtin_expect(!!(x), 0)
> | ^
> include/linux/scatterlist.h:137:2: note: in expansion of macro 'BUG_ON'
> 137 | BUG_ON(!virt_addr_valid(buf));
> | ^~~~~~
> include/linux/scatterlist.h:137:10: note: in expansion of macro 'virt_addr_valid'
> 137 | BUG_ON(!virt_addr_valid(buf));
> | ^~~~~~~~~~~~~~~
Note that the warning is unrelated. I've sent a patch to quiten it.
[PATCH] m68k: Fix virt_addr_valid() W=1 compiler warnings
https://lore.kernel.org/linux-m68k/20210223104957.2209219-1-geert@linux-m68k.org/
> In file included from drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h:7,
> from drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c:14:
> include/linux/if_rmnet.h: At top level:
> >> include/linux/if_rmnet.h:66:2: error: expected ',', ';' or '}' before 'u8'
> 66 | u8 hw_reserved:7;
> | ^~
That's a real one, though.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2021-02-23 10:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 16:55 [PATCH net-next v2 0/3] net: qualcomm: rmnet: Enable Mapv5 Sharath Chandra Vurukala
2021-02-22 16:55 ` [PATCH net-next v2 1/3] docs: networking: Add documentation for MAPv5 Sharath Chandra Vurukala
2021-02-22 16:55 ` [PATCH net-next v2 2/3] net: ethernet: rmnet: Support for downlink MAPv5 checksum offload Sharath Chandra Vurukala
2021-02-22 17:55 ` Alex Elder
2021-02-22 19:49 ` kernel test robot
2021-02-23 10:52 ` Geert Uytterhoeven [this message]
2021-02-22 16:55 ` [PATCH net-next v2 3/3] net: ethernet: rmnet: Add support for Mapv5 uplink packet Sharath Chandra Vurukala
2021-02-22 17:35 ` [PATCH net-next v2 0/3] net: qualcomm: rmnet: Enable Mapv5 subashab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdUTVaRSEt2a_sJSEYX0TCH73xspSXkd--=913dpeSzv0Q@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=cpratapa@codeaurora.org \
--cc=davem@davemloft.net \
--cc=elder@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sharathv@codeaurora.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).