From: Eric Dumazet <edumazet@google.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Gal Pressman <gal@nvidia.com>, Tariq Toukan <tariqt@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Saeed Mahameed <saeedm@nvidia.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH net] tcp: Add a stub for sk_defer_free_flush()
Date: Thu, 20 Jan 2022 08:13:24 -0800 [thread overview]
Message-ID: <CANn89iJ79Zt0eOjdr96GE1dtaO-7e-+0wT54Sa7Q-q-2fzsjtg@mail.gmail.com> (raw)
In-Reply-To: <20220120080530.69cbbcf2@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
On Thu, Jan 20, 2022 at 8:05 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Thu, 20 Jan 2022 04:39:19 -0800 Eric Dumazet wrote:
> > On Thu, Jan 20, 2022 at 4:34 AM Gal Pressman <gal@nvidia.com> wrote:
> > > When compiling the kernel with CONFIG_INET disabled, the
> > > sk_defer_free_flush() should be defined as a nop.
> > >
> > > This resolves the following compilation error:
> > > ld: net/core/sock.o: in function `sk_defer_free_flush':
> > > ./include/net/tcp.h:1378: undefined reference to `__sk_defer_free_flush'
> >
> > Yes, this is one way to fix this, thanks.
>
> Yeah.. isn't it better to move __sk_defer_free_flush and co.
> out of TCP code?
sk->defer_list is currently only fed from tcp_eat_recv_skb(),
I guess we can leave the code, until we have another user than TCP ?
next prev parent reply other threads:[~2022-01-20 16:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 12:34 [PATCH net] tcp: Add a stub for sk_defer_free_flush() Gal Pressman
2022-01-20 12:39 ` Eric Dumazet
2022-01-20 16:05 ` Jakub Kicinski
2022-01-20 16:13 ` Eric Dumazet [this message]
2022-01-20 16:25 ` Jakub Kicinski
2022-01-21 6:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANn89iJ79Zt0eOjdr96GE1dtaO-7e-+0wT54Sa7Q-q-2fzsjtg@mail.gmail.com \
--to=edumazet@google.com \
--cc=davem@davemloft.net \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).