From: Eric Dumazet <edumazet@google.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
netdev <netdev@vger.kernel.org>,
"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
<linux-crypto@vger.kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
David Miller <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Jason Baron <jbaron@akamai.com>,
Christoph Paasch <cpaasch@apple.com>,
David Laight <David.Laight@aculab.com>,
Yuchung Cheng <ycheng@google.com>
Subject: Re: [PATCH 1/2] net: fastopen: make key handling more robust against future changes
Date: Tue, 18 Jun 2019 11:19:11 -0700 [thread overview]
Message-ID: <CANn89iKCGPM03L2dE60VWOfYwbiHj1vRAXvqZuts0Ce-VdpifQ@mail.gmail.com> (raw)
In-Reply-To: <20190618181804.GJ184520@gmail.com>
On Tue, Jun 18, 2019 at 11:18 AM Eric Biggers <ebiggers@kernel.org> wrote:
> The length parameter makes no sense if it's not checked, though. Either it
> should exist and be checked, or it should be removed and the length should be
> implicitly TCP_FASTOPEN_KEY_LENGTH.
Sure, please send a patch.
next prev parent reply other threads:[~2019-06-18 18:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 9:32 [PATCH 0/2] net: fastopen: follow-up tweaks for SipHash switch Ard Biesheuvel
2019-06-18 9:32 ` [PATCH 1/2] net: fastopen: make key handling more robust against future changes Ard Biesheuvel
2019-06-18 9:39 ` Eric Dumazet
2019-06-18 9:41 ` Ard Biesheuvel
2019-06-18 9:53 ` Eric Dumazet
2019-06-18 10:02 ` Ard Biesheuvel
2019-06-18 18:18 ` Eric Biggers
2019-06-18 18:19 ` Eric Dumazet [this message]
2019-06-18 9:32 ` [PATCH 2/2] net: fastopen: use endianness agnostic representation of the cookie Ard Biesheuvel
2019-06-18 18:22 ` Eric Biggers
2019-06-18 18:40 ` Ard Biesheuvel
2019-06-18 22:40 ` David Miller
2019-06-18 9:37 ` [PATCH 0/2] net: fastopen: follow-up tweaks for SipHash switch Eric Dumazet
2019-06-18 9:38 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANn89iKCGPM03L2dE60VWOfYwbiHj1vRAXvqZuts0Ce-VdpifQ@mail.gmail.com \
--to=edumazet@google.com \
--cc=David.Laight@aculab.com \
--cc=ard.biesheuvel@linaro.org \
--cc=cpaasch@apple.com \
--cc=davem@davemloft.net \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=jbaron@akamai.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).