From: Eric Dumazet <edumazet@google.com>
To: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Breno Leitao <leitao@debian.org>,
Kuniyuki Iwashima <kuni1840@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v1 net-next] net: Use sockaddr_storage for getsockopt(SO_PEERNAME).
Date: Thu, 20 Jul 2023 07:01:20 +0200 [thread overview]
Message-ID: <CANn89iLmNtDp7gK2xo_znvh+9-JUyNAW7E2xieLkpBMth96DBw@mail.gmail.com> (raw)
In-Reply-To: <20230720005456.88770-1-kuniyu@amazon.com>
On Thu, Jul 20, 2023 at 2:55 AM Kuniyuki Iwashima <kuniyu@amazon.com> wrote:
>
> Commit df8fc4e934c1 ("kbuild: Enable -fstrict-flex-arrays=3") started
> applying strict rules to standard string functions.
>
> It does not work well with conventional socket code around each protocol-
> specific struct sockaddr_XXX, which is cast from sockaddr_storage and has
> a bigger size than fortified functions expect. (See Link)
>
> We must cast the protocol-specific address back to sockaddr_storage
> to call such functions.
>
> However, in the case of getsockaddr(SO_PEERNAME), the rationale is a bit
> unclear as the buffer is defined by char[128] which is the same size as
> sockaddr_storage.
>
> Let's use sockaddr_storage implicitly.
>
> Link: https://lore.kernel.org/netdev/20230720004410.87588-1-kuniyu@amazon.com/
> Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Thanks.
next prev parent reply other threads:[~2023-07-20 5:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 0:54 [PATCH v1 net-next] net: Use sockaddr_storage for getsockopt(SO_PEERNAME) Kuniyuki Iwashima
2023-07-20 5:01 ` Eric Dumazet [this message]
2023-07-20 13:50 ` Willem de Bruijn
2023-07-20 16:32 ` Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANn89iLmNtDp7gK2xo_znvh+9-JUyNAW7E2xieLkpBMth96DBw@mail.gmail.com \
--to=edumazet@google.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=kuniyu@amazon.com \
--cc=leitao@debian.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).