From: Lijun Pan <lijunp213@gmail.com>
To: Rick Lindsley <ricklind@linux.vnet.ibm.com>
Cc: Lijun Pan <ljp@linux.vnet.ibm.com>,
Dany Madden <drt@linux.ibm.com>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Tom Falcon <tlfalcon@linux.ibm.com>,
netdev@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Sukadev Bhattiprolu <sukadev@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V2 net] ibmvnic: Continue with reset if set link down failed
Date: Thu, 22 Apr 2021 00:12:04 -0500 [thread overview]
Message-ID: <CAOhMmr4YF6HyBfa4gZZFQqUK6tyw5io=WzSb6G08zhbtu1sU-g@mail.gmail.com> (raw)
In-Reply-To: <51a63be8-9b24-3f72-71d0-111959649059@linux.vnet.ibm.com>
On Wed, Apr 21, 2021 at 3:06 AM Rick Lindsley
<ricklind@linux.vnet.ibm.com> wrote:
>
> On 4/20/21 2:42 PM, Lijun Pan wrote:
> >
> > This v2 does not adddress the concerns mentioned in v1.
> > And I think it is better to exit with error from do_reset, and schedule a thorough
> > do_hard_reset if the the adapter is already in unstable state.
>
> But the point is that the testing and analysis has indicated that doing a full
> hard reset is not necessary. We are about to take the very action which will fix
> this situation, but currently do not.
The testing was done on this patch. It was not performed on a full hard reset.
So I don't think you could even compare the two results.
>
> Please describe the advantage in deferring it further by routing it through
> do_hard_reset(). I don't see one.
It is not deferred. It exits with error and calls do_hard_reset.
See my reply to Suka's.
next prev parent reply other threads:[~2021-04-22 5:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 21:35 [PATCH V2 net] ibmvnic: Continue with reset if set link down failed Dany Madden
2021-04-20 21:42 ` Lijun Pan
2021-04-21 6:45 ` Sukadev Bhattiprolu
2021-04-22 5:06 ` Lijun Pan
2021-04-22 6:58 ` Sukadev Bhattiprolu
2021-04-22 7:05 ` Rick Lindsley
2021-04-22 17:21 ` Michal Suchánek
2021-04-22 17:38 ` Lijun Pan
2021-04-23 2:26 ` Rick Lindsley
2021-05-04 19:05 ` Dany Madden
2021-04-21 7:54 ` Rick Lindsley
2021-04-22 5:12 ` Lijun Pan [this message]
2021-04-22 7:05 ` Rick Lindsley
2021-04-22 5:30 ` Lijun Pan
2021-04-22 7:07 ` Rick Lindsley
2021-04-22 17:01 ` Lijun Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOhMmr4YF6HyBfa4gZZFQqUK6tyw5io=WzSb6G08zhbtu1sU-g@mail.gmail.com' \
--to=lijunp213@gmail.com \
--cc=davem@davemloft.net \
--cc=drt@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=ljp@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=ricklind@linux.vnet.ibm.com \
--cc=sukadev@linux.ibm.com \
--cc=tlfalcon@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).