From: Song Liu <liu.song.a23@gmail.com>
To: allanzhang <allanzhang@google.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
"David S. Miller" <davem@davemloft.net>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] bpf: Allow bpf_skb_event_output for a few prog types
Date: Mon, 24 Jun 2019 16:12:36 -0700 [thread overview]
Message-ID: <CAPhsuW7D=bn9R7TnWbEZyj-W-WgdErJVdY-1jQmGP_HtcdkPsw@mail.gmail.com> (raw)
In-Reply-To: <CAPhsuW40c=CTdTo9YUbyj3AAL+A37TX1-Bty267bCYOaThJJ7w@mail.gmail.com>
On Mon, Jun 24, 2019 at 4:10 PM Song Liu <liu.song.a23@gmail.com> wrote:
>
> On Mon, Jun 24, 2019 at 3:08 PM allanzhang <allanzhang@google.com> wrote:
> >
> > Software event output is only enabled by a few prog types right now (TC,
> > LWT out, XDP, sockops). Many other skb based prog types need
> > bpf_skb_event_output to produce software event.
> >
> > Added socket_filter, cg_skb, sk_skb prog types to generate sw event.
> >
> > Test bpf code is generated from code snippet:
> >
> > struct TMP {
> > uint64_t tmp;
> > } tt;
> > tt.tmp = 5;
> > bpf_perf_event_output(skb, &connection_tracking_event_map, 0,
> > &tt, sizeof(tt));
> > return 1;
> >
> > the bpf assembly from llvm is:
> > 0: b7 02 00 00 05 00 00 00 r2 = 5
> > 1: 7b 2a f8 ff 00 00 00 00 *(u64 *)(r10 - 8) = r2
> > 2: bf a4 00 00 00 00 00 00 r4 = r10
> > 3: 07 04 00 00 f8 ff ff ff r4 += -8
> > 4: 18 02 00 00 00 00 00 00 00 00 00 00 00 00 00 00 r2 = 0ll
> > 6: b7 03 00 00 00 00 00 00 r3 = 0
> > 7: b7 05 00 00 08 00 00 00 r5 = 8
> > 8: 85 00 00 00 19 00 00 00 call 25
> > 9: b7 00 00 00 01 00 00 00 r0 = 1
> > 10: 95 00 00 00 00 00 00 00 exit
> >
> > Patch 1 is enabling code.
> > Patch 2 is fullly covered selftest code.
> >
> > Signed-off-by: allanzhang <allanzhang@google.com>
>
> A few logistics issues:
>
> 1. The patch should be sent as a set, as
> [PATCH bpf-next 0/2] ...
> [PATCH bpf-next 1/2] ...
> [PATCH bpf-next 2/2] ...
>
> 2. You need to specify which tree this is targeting. In this case, bpf-next.
> 3. Please use different commit log for each patch.
> 4. No need for Signed-off-by in the cover letter.
>
> Please resubmit. And generate the patches with git command similar to
> the following:
>
> git format-patch --cover-leter --subject_prefix "PATCH bpf-next v2" HEAD~2
>
And your signed-of-by should probably look like:
Signed-off-by: Allan Zhang <allanzhang@google.com>
Thanks,
Song
next prev parent reply other threads:[~2019-06-24 23:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 21:58 [PATCH] bpf: Allow bpf_skb_event_output for a few prog types allanzhang
2019-06-24 21:58 ` allanzhang
2019-06-24 21:58 ` allanzhang
2019-06-24 23:10 ` Song Liu
2019-06-24 23:12 ` Song Liu [this message]
2019-06-25 0:13 allanzhang
2019-06-25 0:13 ` allanzhang
2019-06-25 0:13 ` allanzhang
2019-06-25 12:06 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPhsuW7D=bn9R7TnWbEZyj-W-WgdErJVdY-1jQmGP_HtcdkPsw@mail.gmail.com' \
--to=liu.song.a23@gmail.com \
--cc=allanzhang@google.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=kafai@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).