From: Andrea Claudi <aclaudi@redhat.com>
To: Matteo Croce <mcroce@redhat.com>
Cc: netdev@vger.kernel.org,
Stephen Hemminger <stephen@networkplumber.org>,
David Ahern <dsahern@kernel.org>
Subject: Re: [PATCH iproute2 v2 0/3] refactor the cmd_exec()
Date: Thu, 13 Jun 2019 19:07:20 +0200 [thread overview]
Message-ID: <CAPpH65yOS8OKX1cUDtvjVHwXSTEifbCGXQhMUKg9R-aEbMNnWQ@mail.gmail.com> (raw)
In-Reply-To: <20190611161031.12898-1-mcroce@redhat.com>
On Tue, Jun 11, 2019 at 6:11 PM Matteo Croce <mcroce@redhat.com> wrote:
>
> Refactor the netns and ipvrf code so less steps are needed to exec commands
> in a netns or a VRF context.
> Also remove some code which became dead. bloat-o-meter output:
>
> $ bloat-o-meter ip.old ip
> add/remove: 1/4 grow/shrink: 3/4 up/down: 174/-312 (-138)
> Function old new delta
> netns_add 971 1058 +87
> cmd_exec 207 256 +49
> on_netns_exec 32 60 +28
> do_switch - 10 +10
> netns_restore 69 67 -2
> do_ipvrf 811 802 -9
> netns_switch 838 822 -16
> on_netns_label 45 - -45
> do_netns 1226 1180 -46
> do_each_netns 57 - -57
> on_netns 60 - -60
> netns_save 77 - -77
> Total: Before=668234, After=668096, chg -0.02%
>
> Matteo Croce (3):
> netns: switch netns in the child when executing commands
> ip vrf: use hook to change VRF in the child
> netns: make netns_{save,restore} static
>
> include/namespace.h | 2 --
> include/utils.h | 6 ++---
> ip/ip.c | 1 -
> ip/ipnetns.c | 56 +++++++++++++++++++++++++++++++++------------
> ip/ipvrf.c | 12 ++++++----
> lib/exec.c | 7 +++++-
> lib/namespace.c | 31 -------------------------
> lib/utils.c | 27 ----------------------
> 8 files changed, 58 insertions(+), 84 deletions(-)
>
> --
> 2.21.0
>
For patch series:
Reviewed-and-tested-by: Andrea Claudi <aclaudi@redhat.com>
next prev parent reply other threads:[~2019-06-13 17:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 16:10 [PATCH iproute2 v2 0/3] refactor the cmd_exec() Matteo Croce
2019-06-11 16:10 ` [PATCH iproute2 v2 1/3] netns: switch netns in the child when executing commands Matteo Croce
2019-06-11 16:10 ` [PATCH iproute2 v2 2/3] ip vrf: use hook to change VRF in the child Matteo Croce
2019-06-11 16:10 ` [PATCH iproute2 v2 3/3] netns: make netns_{save,restore} static Matteo Croce
2019-06-13 17:07 ` Andrea Claudi [this message]
2019-06-14 14:35 ` [PATCH iproute2 v2 0/3] refactor the cmd_exec() David Ahern
2019-06-15 14:06 ` Matteo Croce
2019-06-17 22:20 ` Matteo Croce
2019-06-17 22:24 ` David Ahern
2019-06-18 14:49 Matteo Croce
2019-06-18 15:41 ` Matteo Croce
2019-06-20 21:31 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPpH65yOS8OKX1cUDtvjVHwXSTEifbCGXQhMUKg9R-aEbMNnWQ@mail.gmail.com \
--to=aclaudi@redhat.com \
--cc=dsahern@kernel.org \
--cc=mcroce@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).