netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Starovoytov <mstarovoitov@marvell.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"David S . Miller" <davem@davemloft.net>,
	Dmitry Bezrukov <dbezrukov@marvell.com>,
	Igor Russkikh <irusskikh@marvell.com>
Subject: RE: [EXT] Re: [PATCH v2 net-next 01/12] net: atlantic: changes for multi-TC support
Date: Fri, 22 May 2020 19:47:37 +0000	[thread overview]
Message-ID: <CH2PR18MB3238B6DC3153AF4A38038454D3B40@CH2PR18MB3238.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20200522105831.4ab00ca5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

Hi Jakub,

Thank you for the review.

> > This patch contains the following changes:
> > * access cfg via aq_nic_get_cfg() in aq_nic_start() and
> > aq_nic_map_skb();
...
> > * use AQ_HW_*_TC instead of hardcoded magic numbers;
> > * actually use the 'ret' value in aq_mdo_add_secy();
> 
> Whenever you do an enumeration like this - it's a strong indication that those
> should all be separate patches. Please keep that in mind going forward.

Understood, but I've also seen a recommendation that a single patchset shouldn't have more than 15 patches (if my memory doesn't fail me). And unfortunately it would have been impossible to meet the 15 patches limit, if all these small changes were in separate patches. What's the best/recommended approach in this case?

> >  static int aq_mdo_upd_secy(struct macsec_context *ctx)
> 
> This should have been a separate fix for sure.

My bad, note taken.

Best regards,
Mark.

  reply	other threads:[~2020-05-22 19:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-22  8:19 [PATCH v2 net-next 00/12] net: atlantic: QoS implementation Igor Russkikh
2020-05-22  8:19 ` [PATCH v2 net-next 01/12] net: atlantic: changes for multi-TC support Igor Russkikh
2020-05-22 17:58   ` Jakub Kicinski
2020-05-22 19:47     ` Mark Starovoytov [this message]
2020-05-25 20:09       ` [EXT] " Jakub Kicinski
2020-05-22  8:19 ` [PATCH v2 net-next 02/12] net: atlantic: move PTP TC initialization to a separate function Igor Russkikh
2020-05-22  8:19 ` [PATCH v2 net-next 03/12] net: atlantic: changes for multi-TC support Igor Russkikh
2020-05-22  8:19 ` [PATCH v2 net-next 04/12] net: atlantic: QoS implementation: " Igor Russkikh
2020-05-22  8:19 ` [PATCH v2 net-next 05/12] net: atlantic: per-TC queue statistics Igor Russkikh
2020-05-22  8:19 ` [PATCH v2 net-next 06/12] net: atlantic: make TCVEC2RING accept nic_cfg Igor Russkikh
2020-05-22  8:19 ` [PATCH v2 net-next 07/12] net: atlantic: QoS implementation: max_rate Igor Russkikh
2020-05-22  8:19 ` [PATCH v2 net-next 08/12] net: atlantic: automatically downgrade the number of queues if necessary Igor Russkikh
2020-05-22  8:19 ` [PATCH v2 net-next 09/12] net: atlantic: always use random TC-queue mapping for TX on A2 Igor Russkikh
2020-05-22  8:19 ` [PATCH v2 net-next 10/12] net: atlantic: change the order of arguments for TC weight/credit setters Igor Russkikh
2020-05-22  8:19 ` [PATCH v2 net-next 11/12] net: atlantic: QoS implementation: min_rate Igor Russkikh
2020-05-22  8:19 ` [PATCH v2 net-next 12/12] net: atlantic: proper rss_ctrl1 (54c0) initialization Igor Russkikh
2020-05-22 17:58 ` [PATCH v2 net-next 00/12] net: atlantic: QoS implementation Jakub Kicinski
2020-05-22 21:08   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CH2PR18MB3238B6DC3153AF4A38038454D3B40@CH2PR18MB3238.namprd18.prod.outlook.com \
    --to=mstarovoitov@marvell.com \
    --cc=davem@davemloft.net \
    --cc=dbezrukov@marvell.com \
    --cc=irusskikh@marvell.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).