netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geethasowjanya Akula <gakula@marvell.com>
To: Dan Carpenter <error27@gmail.com>,
	Sunil Kovvuri Goutham <sgoutham@marvell.com>
Cc: Linu Cherian <lcherian@marvell.com>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	Hariprasad Kelam <hkelam@marvell.com>,
	Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Vamsi Krishna Attunuru <vattunuru@marvell.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>
Subject: Re: [EXT] [PATCH net] octeontx2-af: cn10k: mcs: Fix copy and paste bug in mcs_bbe_intr_handler()
Date: Mon, 21 Nov 2022 08:00:07 +0000	[thread overview]
Message-ID: <DM6PR18MB2602D92B07F140B616729203CD0A9@DM6PR18MB2602.namprd18.prod.outlook.com> (raw)
In-Reply-To: <Y3efyh1HjbToppbN@kili>

ACK.
Thanks for the patch.

Geetha.

________________________________________
From: Dan Carpenter <error27@gmail.com>
Sent: Friday, November 18, 2022 8:37 PM
To: Sunil Kovvuri Goutham; Geethasowjanya Akula
Cc: Linu Cherian; Jerin Jacob Kollanukkaran; Hariprasad Kelam; Subbaraya Sundeep Bhatta; David S. Miller; Eric Dumazet; Jakub Kicinski; Paolo Abeni; Vamsi Krishna Attunuru; netdev@vger.kernel.org; kernel-janitors@vger.kernel.org
Subject: [EXT] [PATCH net] octeontx2-af: cn10k: mcs: Fix copy and paste bug in mcs_bbe_intr_handler()

External Email

----------------------------------------------------------------------
This code accidentally uses the RX macro twice instead of the RX and TX.

Fixes: 6c635f78c474 ("octeontx2-af: cn10k: mcs: Handle MCS block interrupts")
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
Applies to net.

 drivers/net/ethernet/marvell/octeontx2/af/mcs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/octeontx2/af/mcs.c b/drivers/net/ethernet/marvell/octeontx2/af/mcs.c
index 4a343f853b28..c0bedf402da9 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/mcs.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/mcs.c
@@ -951,7 +951,7 @@ static void mcs_bbe_intr_handler(struct mcs *mcs, u64 intr, enum mcs_direction d
                else
                        event.intr_mask = (dir == MCS_RX) ?
                                          MCS_BBE_RX_PLFIFO_OVERFLOW_INT :
-                                         MCS_BBE_RX_PLFIFO_OVERFLOW_INT;
+                                         MCS_BBE_TX_PLFIFO_OVERFLOW_INT;

                /* Notify the lmac_id info which ran into BBE fatal error */
                event.lmac_id = i & 0x3ULL;
--
2.35.1


  reply	other threads:[~2022-11-21  8:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-18 15:07 [PATCH net] octeontx2-af: cn10k: mcs: Fix copy and paste bug in mcs_bbe_intr_handler() Dan Carpenter
2022-11-21  8:00 ` Geethasowjanya Akula [this message]
2022-11-21 13:10 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR18MB2602D92B07F140B616729203CD0A9@DM6PR18MB2602.namprd18.prod.outlook.com \
    --to=gakula@marvell.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=error27@gmail.com \
    --cc=hkelam@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=lcherian@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sbhatta@marvell.com \
    --cc=sgoutham@marvell.com \
    --cc=vattunuru@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).