From: <Narendra_K@Dell.com>
To: <john.fastabend@gmail.com>
Cc: <bhutchings@solarflare.com>, <netdev@vger.kernel.org>,
<john.r.fastabend@intel.com>
Subject: RE: [PATCH net-next] net: Add phys_port identifier to struct net_device and export it to sysfs
Date: Tue, 25 Jun 2013 10:33:31 -0700 [thread overview]
Message-ID: <E31FB011129F30488D5861F383904915210BC0481A@BLRX7MCDC201.AMER.DELL.COM> (raw)
In-Reply-To: <51C4892B.8000806@gmail.com>
> -----Original Message-----
> From: John Fastabend [mailto:john.fastabend@gmail.com]
> Sent: Friday, June 21, 2013 10:41 PM
> To: K, Narendra
> Cc: Ben Hutchings; netdev@vger.kernel.org; john.r.fastabend@intel.com
> Subject: Re: [PATCH net-next] net: Add phys_port identifier to struct
> net_device and export it to sysfs
>
> On 06/19/2013 12:34 PM, Ben Hutchings wrote:
[...]
> > I think so.
> >
> >> If correct, I think the 'show_broadcast' function also needs to be
> >> fixed as it is not holding the lock.
> >
> > I think the broadcast address should never change during the lifetime
> > of a device, so it doesn't need the lock. That might not be true for
> > all layer 2 protocols though.
> >
> > Ben.
> >
>
> Also, do you think this will be primarily useful for partitioning devices that
> expose multiple physical functions? Or do you see a use case for SR-IOV with
> virtual functions as well. The pyhs_port attribute provides a common
> interface for both cases which is good I suppose in the VF case however the
> host can already learn this. I gather from your original post here that you are
> aware of all this.
>
John, I think it will be useful in the SRIOV scenario also when more than one VF from two NICs are assigned to the guest. phys_port would be helpful in choosing the correct slave interfaces when host details are not available.
With regards,
Narendra K
Linux Engineering
Dell Inc.
next prev parent reply other threads:[~2013-06-25 17:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 18:10 [PATCH net-next] net: Add phys_port identifier to struct net_device and export it to sysfs Narendra_K
2013-06-17 18:47 ` John Fastabend
2013-06-19 14:29 ` Narendra_K
2013-06-19 15:36 ` Ben Hutchings
2013-06-19 18:53 ` Narendra_K
2013-06-19 19:34 ` Ben Hutchings
2013-06-19 21:37 ` Praveen_Paladugu
2013-06-21 17:11 ` John Fastabend
2013-06-25 17:33 ` Narendra_K [this message]
2013-06-28 16:33 ` John Fastabend
2013-06-28 17:09 ` Ben Hutchings
2013-07-02 14:40 ` Narendra_K
2013-07-11 20:39 ` Jiri Pirko
2013-07-15 15:34 ` Narendra_K
2013-07-21 5:55 ` Or Gerlitz
2013-07-21 7:24 ` Jiri Pirko
2013-07-21 11:14 ` Or Gerlitz
2013-07-21 14:48 ` Ben Hutchings
2013-07-21 20:29 ` Or Gerlitz
2013-07-21 20:50 ` Ben Hutchings
2013-07-22 11:46 ` Narendra_K
2013-07-22 11:49 ` Jiri Pirko
2013-07-22 15:48 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E31FB011129F30488D5861F383904915210BC0481A@BLRX7MCDC201.AMER.DELL.COM \
--to=narendra_k@dell.com \
--cc=bhutchings@solarflare.com \
--cc=john.fastabend@gmail.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).